Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: systemd : /usr/share/doc/systemd/sd-readahead.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in systemd- libs , systemd-devel , systemd-sysv , systemd-analyze , systemd-python , libgudev1 , libgudev1-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 133120 bytes in 9 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: The placement of pkgconfig(.pc) files are correct. Note: systemd : /usr/share/pkgconfig/systemd.pc systemd : /usr/share/pkgconfig/udev.pc [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1249280 bytes in /usr/share 583680 systemd-197-2.fc19.x86_64.rpm 409600 systemd-devel-197-2.fc19.x86_64.rpm 256000 libgudev1-devel-197-2.fc19.x86_64.rpm Rpmlint ------- Checking: systemd-197-2.fc19.x86_64.rpm systemd-libs-197-2.fc19.x86_64.rpm systemd-devel-197-2.fc19.x86_64.rpm systemd-sysv-197-2.fc19.x86_64.rpm systemd-analyze-197-2.fc19.x86_64.rpm systemd-python-197-2.fc19.x86_64.rpm libgudev1-197-2.fc19.x86_64.rpm libgudev1-devel-197-2.fc19.x86_64.rpm systemd.x86_64: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization systemd.x86_64: W: spelling-error %description -l en_US cgroups -> groups, c groups systemd.x86_64: W: spelling-error %description -l en_US snapshotting -> snaps hotting, snaps-hotting, snapshot ting systemd.x86_64: W: spelling-error %description -l en_US automount -> auto mount, auto-mount, autonomous systemd.x86_64: W: spelling-error %description -l en_US transactional -> transaction, transnational, transitional systemd.x86_64: W: obsolete-not-provided upstart systemd.x86_64: W: obsolete-not-provided upstart-sysvinit systemd.x86_64: W: self-obsoletion systemd-sysvinit obsoletes systemd-sysvinit systemd.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/systemd-bash-completion.sh systemd.x86_64: W: non-conffile-in-etc /etc/rpm/macros.systemd systemd.x86_64: W: devel-file-in-non-devel-package /usr/share/pkgconfig/systemd.pc systemd.x86_64: W: non-conffile-in-etc /etc/rc.d/init.d/README systemd.x86_64: E: script-without-shebang /etc/rc.d/init.d/README systemd.x86_64: E: non-executable-script /etc/rc.d/init.d/README 0644L None systemd.x86_64: W: devel-file-in-non-devel-package /usr/share/pkgconfig/udev.pc systemd.x86_64: E: non-readable /etc/X11/xorg.conf.d/00-system-setup-keyboard.conf 0L systemd.x86_64: W: no-manual-page-for-binary systemd-stdio-bridge systemd.x86_64: W: no-manual-page-for-binary systemd-loginctl systemd.x86_64: W: dangerous-command-in-%pre mv systemd.x86_64: W: dangerous-command-in-%post ln systemd.x86_64: W: dangerous-command-in-%preun rm systemd.x86_64: W: dangerous-command-in-%trigger mv systemd.x86_64: W: dangerous-command-in-%trigger mv systemd.x86_64: W: dangerous-command-in-%posttrans ln systemd.x86_64: E: init-script-non-executable /etc/rc.d/init.d/README systemd.x86_64: E: postin-without-chkconfig /etc/rc.d/init.d/README systemd.x86_64: E: preun-without-chkconfig /etc/rc.d/init.d/README systemd.x86_64: E: no-status-entry /etc/rc.d/init.d/README systemd.x86_64: W: no-reload-entry /etc/rc.d/init.d/README systemd.x86_64: E: no-chkconfig-line /etc/rc.d/init.d/README systemd.x86_64: E: subsys-not-used /etc/rc.d/init.d/README systemd.x86_64: W: incoherent-init-script-name README ('systemd', 'systemdd') systemd-libs.x86_64: W: summary-not-capitalized C systemd libraries systemd-libs.x86_64: W: spelling-error %description -l en_US udev -> dude systemd-libs.x86_64: W: obsolete-not-provided libudev systemd-libs.x86_64: W: obsolete-not-provided systemd systemd-libs.x86_64: W: no-documentation systemd-sysv.x86_64: W: no-documentation systemd-sysv.x86_64: W: no-manual-page-for-binary systemd-sysv-convert systemd-analyze.x86_64: W: obsolete-not-provided systemd systemd-analyze.x86_64: W: no-documentation systemd-analyze.x86_64: W: no-manual-page-for-binary systemd-analyze systemd-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/systemd/_journal.so _journal.so()(64bit) systemd-python.x86_64: W: no-documentation libgudev1.x86_64: W: spelling-error Summary(en_US) libudev -> Libreville libgudev1.x86_64: W: spelling-error %description -l en_US libudev -> Libreville libgudev1.x86_64: W: no-documentation libgudev1-devel.x86_64: W: spelling-error Summary(en_US) libudev -> Libreville libgudev1-devel.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure libgudev1-devel.x86_64: W: spelling-error %description -l en_US libudev -> Libreville 8 packages and 0 specfiles checked; 9 errors, 41 warnings. Requires -------- systemd (rpmlib, GLIBC filtered): /bin/sh /usr/bin/getent /usr/sbin/groupadd config(systemd) coreutils dbus filesystem gawk ld-linux-x86-64.so.2()(64bit) libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libaudit.so.1()(64bit) libblkid.so.1()(64bit) libblkid.so.1(BLKID_2.15)(64bit) libblkid.so.1(BLKID_2.17)(64bit) libblkid.so.1(BLKID_2.18)(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcryptsetup.so.4()(64bit) libcryptsetup.so.4(CRYPTSETUP_1.0)(64bit) libdbus-1.so.3()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcrypt.so.11()(64bit) libgcrypt.so.11(GCRYPT_1.2)(64bit) libkmod.so.2()(64bit) libkmod.so.2(LIBKMOD_5)(64bit) liblzma.so.5()(64bit) liblzma.so.5(XZ_5.0)(64bit) libm.so.6()(64bit) libmicrohttpd.so.10()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libqrencode.so.3()(64bit) librt.so.1()(64bit) libselinux.so.1()(64bit) libsystemd-daemon.so.0()(64bit) libsystemd-daemon.so.0(LIBSYSTEMD_DAEMON_31)(64bit) libsystemd-journal.so.0()(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_196)(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_38)(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libudev.so.1(LIBUDEV_189)(64bit) libwrap.so.0()(64bit) nss-myhostname rtld(GNU_HASH) sed systemd-libs systemd-devel (rpmlib, GLIBC filtered): libsystemd-daemon.so.0()(64bit) libsystemd-id128.so.0()(64bit) libsystemd-journal.so.0()(64bit) libsystemd-login.so.0()(64bit) libudev.so.1()(64bit) pkgconfig(libsystemd-id128) systemd systemd-libs (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libdbus-1.so.3()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcrypt.so.11()(64bit) libgcrypt.so.11(GCRYPT_1.2)(64bit) libgpg-error.so.0()(64bit) liblzma.so.5()(64bit) liblzma.so.5(XZ_5.0)(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpam.so.0(LIBPAM_EXTENSION_1.0)(64bit) libpam.so.0(LIBPAM_MODUTIL_1.0)(64bit) libpam_misc.so.0()(64bit) libpam_misc.so.0(LIBPAM_MISC_1.0)(64bit) librt.so.1()(64bit) libselinux.so.1()(64bit) libsystemd-daemon.so.0()(64bit) libsystemd-daemon.so.0(LIBSYSTEMD_DAEMON_31)(64bit) rtld(GNU_HASH) libgudev1-devel (rpmlib, GLIBC filtered): libgudev-1.0.so.0()(64bit) libgudev1 pkgconfig(glib-2.0) pkgconfig(gobject-2.0) systemd-python (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libgcrypt.so.11()(64bit) libgpg-error.so.0()(64bit) liblzma.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) librt.so.1()(64bit) libselinux.so.1()(64bit) libsystemd-daemon.so.0()(64bit) libsystemd-journal.so.0()(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_38)(64bit) libutil.so.1()(64bit) python(abi) rtld(GNU_HASH) systemd libgudev1 (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) librt.so.1()(64bit) libsystemd-daemon.so.0()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) rtld(GNU_HASH) systemd systemd-sysv (rpmlib, GLIBC filtered): /usr/bin/python systemd systemd-analyze (rpmlib, GLIBC filtered): /usr/bin/python pycairo pygobject3-base systemd Provides -------- systemd: /bin/systemctl /sbin/shutdown SysVinit config(systemd) nss-myhostname pkgconfig(systemd) pkgconfig(udev) readahead syslog system-setup-keyboard systemd systemd(x86-64) systemd-sysvinit systemd-units sysvinit sysvinit-userspace udev systemd-devel: libudev-devel pkgconfig(libsystemd-daemon) pkgconfig(libsystemd-id128) pkgconfig(libsystemd-journal) pkgconfig(libsystemd-login) pkgconfig(libudev) systemd-devel systemd-devel(x86-64) systemd-libs: libnss_myhostname.so.2()(64bit) libsystemd-daemon.so.0()(64bit) libsystemd-daemon.so.0(LIBSYSTEMD_DAEMON_31)(64bit) libsystemd-id128.so.0()(64bit) libsystemd-id128.so.0(LIBSYSTEMD_ID128_38)(64bit) libsystemd-journal.so.0()(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_183)(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_184)(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_187)(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_188)(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_190)(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_195)(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_196)(64bit) libsystemd-journal.so.0(LIBSYSTEMD_JOURNAL_38)(64bit) libsystemd-login.so.0()(64bit) libsystemd-login.so.0(LIBSYSTEMD_LOGIN_186)(64bit) libsystemd-login.so.0(LIBSYSTEMD_LOGIN_31)(64bit) libsystemd-login.so.0(LIBSYSTEMD_LOGIN_38)(64bit) libsystemd-login.so.0(LIBSYSTEMD_LOGIN_43)(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libudev.so.1(LIBUDEV_189)(64bit) libudev.so.1(LIBUDEV_196)(64bit) pam_systemd.so()(64bit) systemd-libs systemd-libs(x86-64) libgudev1-devel: libgudev1-devel libgudev1-devel(x86-64) pkgconfig(gudev-1.0) systemd-python: _journal.so()(64bit) systemd-python systemd-python(x86-64) libgudev1: libgudev-1.0.so.0()(64bit) libgudev1 libgudev1(x86-64) systemd-sysv: systemd-sysv systemd-sysv(x86-64) systemd-analyze: systemd-analyze systemd-analyze(x86-64) Unversioned so-files -------------------- systemd-libs: /usr/lib64/security/pam_systemd.so systemd-python: /usr/lib64/python2.7/site-packages/systemd/_journal.so MD5-sum check ------------- http://www.freedesktop.org/software/systemd/systemd-197.tar.xz : CHECKSUM(SHA256) this package : e6857ea21ae24d7056e7b0f4c2aaaba73b8bf57025b8949c0a8af0c1bc9774b5 CHECKSUM(SHA256) upstream package : e6857ea21ae24d7056e7b0f4c2aaaba73b8bf57025b8949c0a8af0c1bc9774b5 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn systemd -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires