Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in thermostat See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find find-files-with-missing-license in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in thermostat- javadoc [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 3 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Can't find any BUILD directory (--prebuilt option?) [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Fully versioned dependency in subpackages, if present. [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 28160000 bytes in /usr/share 26511360 thermostat-javadoc-0.5.0-0.26.20121123hgd6145521e208.fc19.x86_64.rpm 1648640 thermostat-0.5.0-0.26.20121123hgd6145521e208.fc19.x86_64.rpm Rpmlint ------- Checking: thermostat-0.5.0-0.26.20121123hgd6145521e208.fc19.x86_64.rpm thermostat-javadoc-0.5.0-0.26.20121123hgd6145521e208.fc19.x86_64.rpm thermostat.x86_64: E: devel-dependency java-devel thermostat.x86_64: E: explicit-lib-dependency libgnome-keyring thermostat.x86_64: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/commons-io.jar /usr/share/java/apache-commons-io.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/commons-fileupload.jar /usr/share/java/apache-commons-fileupload.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/tools.jar /usr/lib/jvm/java-openjdk/lib/tools.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/hawtjni-runtime.jar /usr/share/java/hawtjni-runtime.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/lucene.jar /usr/share/java/lucene.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jetty-http.jar /usr/share/jetty/lib/jetty-http-8.1.5.v20120716.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/commons-codec.jar /usr/share/java/apache-commons-codec.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jetty-io.jar /usr/share/jetty/lib/jetty-io-8.1.5.v20120716.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jcommon.jar /usr/share/java/jcommon.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/httpcomponents-mime.jar /usr/share/java/httpcomponents/httpmime.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jetty-server.jar /usr/share/jetty/lib/jetty-server-8.1.5.v20120716.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/commons-cli.jar /usr/share/java/apache-commons-cli.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jetty-xml.jar /usr/share/jetty/lib/jetty-xml-8.1.5.v20120716.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jansi.jar /usr/share/java/jansi.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jetty-util.jar /usr/share/jetty/lib/jetty-util-8.1.5.v20120716.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/commons-logging.jar /usr/share/java/apache-commons-logging.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jline2.jar /usr/share/java/jline2.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/commons-collections.jar /usr/share/java/apache-commons-collections.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/gson.jar /usr/share/java/google-gson.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/mongo.jar /usr/share/java/mongo.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jetty-servlet.jar /usr/share/jetty/lib/jetty-servlet-8.1.5.v20120716.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/httpcomponents-core.jar /usr/share/java/httpcomponents/httpcore.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jetty-security.jar /usr/share/jetty/lib/jetty-security-8.1.5.v20120716.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/netty.jar /usr/share/java/netty.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/org.apache.felix.framework.jar /usr/share/java/felix/org.apache.felix.framework.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jfreechart.jar /usr/share/java/jfreechart/jfreechart.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/commons-beanutils.jar /usr/share/java/apache-commons-beanutils.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/httpcomponents-client.jar /usr/share/java/httpcomponents/httpclient.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jetty-continuation.jar /usr/share/jetty/lib/jetty-continuation-8.1.5.v20120716.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/javax-servlet.jar /usr/share/java/tomcat-servlet-api.jar thermostat.x86_64: W: dangling-symlink /usr/share/thermostat/libs/jetty-webapp.jar /usr/share/jetty/lib/jetty-webapp-8.1.5.v20120716.jar thermostat.x86_64: W: no-manual-page-for-binary thermostat-client thermostat.x86_64: W: no-manual-page-for-binary thermostat thermostat-javadoc.x86_64: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 2 packages and 0 specfiles checked; 2 errors, 35 warnings. Requires -------- thermostat-javadoc (rpmlib, GLIBC filtered): jpackage-utils thermostat (rpmlib, GLIBC filtered): /bin/bash /usr/bin/env apache-commons-beanutils apache-commons-cli apache-commons-codec apache-commons-fileupload apache-commons-logging config(thermostat) felix-framework google-gson httpcomponents-client httpcomponents-core jansi java java-devel jcommon jetty jfreechart jline2 jpackage-utils libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgnome-keyring libgnome-keyring.so.0()(64bit) lucene mongo-java-driver mongo-java-driver-bson mongodb mongodb-server netty rtld(GNU_HASH) Provides -------- thermostat-javadoc: thermostat-javadoc thermostat-javadoc(x86-64) thermostat: config(thermostat) libGnomeKeyringWrapper.so()(64bit) libHostNameWrapper.so()(64bit) osgi(com.redhat.thermostat.agent.cli) osgi(com.redhat.thermostat.agent.command) osgi(com.redhat.thermostat.agent.core) osgi(com.redhat.thermostat.agent.heapdumper) osgi(com.redhat.thermostat.backend.system) osgi(com.redhat.thermostat.bundles.core) osgi(com.redhat.thermostat.client.classstat.core) osgi(com.redhat.thermostat.client.classstat.swing) osgi(com.redhat.thermostat.client.command) osgi(com.redhat.thermostat.client.core) osgi(com.redhat.thermostat.client.heapdumper.core) osgi(com.redhat.thermostat.client.heapdumper.swing) osgi(com.redhat.thermostat.client.stats.memory.core) osgi(com.redhat.thermostat.client.stats.memory.swing) osgi(com.redhat.thermostat.client.swing) osgi(com.redhat.thermostat.common.command) osgi(com.redhat.thermostat.common.core) osgi(com.redhat.thermostat.filter.livingvm.core) osgi(com.redhat.thermostat.filter.livingvm.swing) osgi(com.redhat.thermostat.gc.remote.client.common) osgi(com.redhat.thermostat.gc.remote.client.swing) osgi(com.redhat.thermostat.gc.remote.command) osgi(com.redhat.thermostat.gc.remote.common.command) osgi(com.redhat.thermostat.keyring) osgi(com.redhat.thermostat.killvm.agent) osgi(com.redhat.thermostat.killvm.client) osgi(com.redhat.thermostat.laf.dolphin) osgi(com.redhat.thermostat.launcher) osgi(com.redhat.thermostat.main) osgi(com.redhat.thermostat.process) osgi(com.redhat.thermostat.storage.core) osgi(com.redhat.thermostat.thread.client.common) osgi(com.redhat.thermostat.thread.client.controller) osgi(com.redhat.thermostat.thread.client.swing) osgi(com.redhat.thermostat.thread.collector) osgi(com.redhat.thermostat.thread.harvester) osgi(com.redhat.thermostat.tools) osgi(com.redhat.thermostat.web.client) osgi(com.redhat.thermostat.web.cmd) osgi(com.redhat.thermostat.web.common) osgi(com.redhat.thermostat.web.server) thermostat thermostat(x86-64) Unversioned so-files -------------------- thermostat: /usr/lib64/thermostat/libGnomeKeyringWrapper.so thermostat: /usr/lib64/thermostat/libHostNameWrapper.so thermostat: /usr/share/thermostat/libs/native/libGnomeKeyringWrapper.so thermostat: /usr/share/thermostat/libs/native/libHostNameWrapper.so Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn thermostat -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires