Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in tomcat-admin- webapps, tomcat-docs-webapp, tomcat-systemv, tomcat-jsvc, tomcat-lib, tomcat-webapps See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage - Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tomcat- admin-webapps , tomcat-docs-webapp , tomcat-javadoc , tomcat-systemv , tomcat-jsvc , tomcat-lib , tomcat-webapps [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 194560 bytes in 5 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Can't find any BUILD directory (--prebuilt option?) [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [ ]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: tomcat-7.0.34-1.fc19.noarch.rpm tomcat-admin-webapps-7.0.34-1.fc19.noarch.rpm tomcat-docs-webapp-7.0.34-1.fc19.noarch.rpm tomcat-javadoc-7.0.34-1.fc19.noarch.rpm tomcat-systemv-7.0.34-1.fc19.noarch.rpm tomcat-jsvc-7.0.34-1.fc19.noarch.rpm tomcat-lib-7.0.34-1.fc19.noarch.rpm tomcat-webapps-7.0.34-1.fc19.noarch.rpm tomcat.noarch: W: spelling-error %description -l en_US servlet -> settler tomcat.noarch: W: only-non-binary-in-usr-lib tomcat.noarch: E: non-standard-dir-perm /usr/share/tomcat 0775L tomcat.noarch: E: non-standard-dir-perm /var/log/tomcat 0770L tomcat.noarch: E: non-standard-dir-perm /var/lib/tomcat/webapps 0775L tomcat.noarch: E: non-standard-dir-perm /etc/tomcat/Catalina/localhost 0775L tomcat.noarch: W: dangling-symlink /usr/share/tomcat/lib /usr/share/java/tomcat tomcat.noarch: E: non-readable /etc/tomcat/tomcat-users.xml 0660L tomcat.noarch: E: non-standard-dir-perm /var/cache/tomcat 0770L tomcat.noarch: E: non-standard-dir-perm /etc/tomcat/Catalina 0775L tomcat.noarch: E: non-standard-dir-perm /var/cache/tomcat/work 0770L tomcat.noarch: E: non-standard-dir-perm /var/cache/tomcat/temp 0770L tomcat.noarch: E: zero-length /var/run/tomcat.pid tomcat.noarch: W: no-manual-page-for-binary tomcat-digest tomcat.noarch: W: no-manual-page-for-binary tomcat-sysd tomcat.noarch: W: no-manual-page-for-binary tomcat-tool-wrapper tomcat.noarch: W: no-manual-page-for-binary tomcat tomcat.noarch: W: dangerous-command-in-%preun rm tomcat-admin-webapps.noarch: W: no-documentation tomcat-docs-webapp.noarch: W: no-documentation tomcat-systemv.noarch: W: no-documentation tomcat-systemv.noarch: W: dangling-relative-symlink /usr/sbin/dtomcat tomcat tomcat-systemv.noarch: W: no-manual-page-for-binary dtomcat tomcat-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat ${NAME} tomcat-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat ${NAME} tomcat-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat ${NAME} tomcat-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat ${NAME} tomcat-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat ${NAME} tomcat-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat ${NAME} tomcat-systemv.noarch: W: incoherent-init-script-name tomcat ('tomcat-systemv', 'tomcat-systemvd') tomcat-jsvc.noarch: W: spelling-error %description -l en_US Systemd -> Systems, System, System d tomcat-jsvc.noarch: W: only-non-binary-in-usr-lib tomcat-jsvc.noarch: W: no-documentation tomcat-jsvc.noarch: W: no-manual-page-for-binary tomcat-jsvc tomcat-jsvc.noarch: W: no-manual-page-for-binary tomcat-jsvc-sysd tomcat-lib.noarch: W: no-documentation tomcat-lib.noarch: W: dangling-relative-symlink /usr/share/java/tomcat/tomcat-jsp-2.2-api.jar ../tomcat-jsp-2.2-api.jar tomcat-lib.noarch: W: dangling-relative-symlink /usr/share/java/tomcat/tomcat-servlet-3.0-api.jar ../tomcat-servlet-3.0-api.jar tomcat-lib.noarch: W: dangling-symlink /usr/share/java/tomcat/commons-collections.jar /usr/share/java/apache-commons-collections.jar tomcat-lib.noarch: W: dangling-symlink /usr/share/java/tomcat/jasper-jdt.jar /usr/share/java/ecj.jar tomcat-lib.noarch: W: dangling-symlink /usr/share/java/tomcat/log4j.jar /usr/share/java/log4j.jar tomcat-lib.noarch: W: dangling-symlink /usr/share/java/tomcat/commons-dbcp.jar /usr/share/java/apache-commons-dbcp.jar tomcat-webapps.noarch: W: no-documentation tomcat-webapps.noarch: W: dangling-symlink /var/lib/tomcat/webapps/examples/WEB-INF/lib/standard.jar /usr/share/java/jakarta-taglibs-standard.jar tomcat-webapps.noarch: W: dangling-symlink /var/lib/tomcat/webapps/examples/WEB-INF/lib/jstl.jar /usr/share/java/jakarta-taglibs-core.jar 8 packages and 0 specfiles checked; 10 errors, 35 warnings. Requires -------- tomcat (rpmlib, GLIBC filtered): /bin/sh apache-commons-collections apache-commons-daemon apache-commons-dbcp apache-commons-logging apache-commons-pool chkconfig config(tomcat) java procps shadow-utils systemd-units tomcat-lib tomcat-admin-webapps (rpmlib, GLIBC filtered): tomcat tomcat-webapps (rpmlib, GLIBC filtered): jakarta-taglibs-standard tomcat tomcat-lib (rpmlib, GLIBC filtered): apache-commons-collections apache-commons-dbcp apache-commons-pool coreutils ecj jpackage-utils tomcat-el-2.2-api tomcat-jsp-2.2-api tomcat-servlet-3.0-api tomcat-docs-webapp (rpmlib, GLIBC filtered): tomcat tomcat-jsvc (rpmlib, GLIBC filtered): apache-commons-daemon-jsvc tomcat tomcat-systemv (rpmlib, GLIBC filtered): /bin/sh chkconfig tomcat tomcat-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- tomcat: config(tomcat) tomcat tomcat-admin-webapps: tomcat-admin-webapps tomcat-webapps: tomcat-webapps tomcat-lib: mvn(org.apache.tomcat:tomcat-annotations-api) mvn(org.apache.tomcat:tomcat-api) mvn(org.apache.tomcat:tomcat-catalina) mvn(org.apache.tomcat:tomcat-catalina-ha) mvn(org.apache.tomcat:tomcat-coyote) mvn(org.apache.tomcat:tomcat-jasper) mvn(org.apache.tomcat:tomcat-jasper-el) mvn(org.apache.tomcat:tomcat-juli) mvn(org.apache.tomcat:tomcat-tribes) mvn(org.apache.tomcat:tomcat-util) osgi(org.apache.el) osgi(org.apache.jasper) osgi(org.apache.juli) osgi(org.apache.tomcat) osgi(org.apache.tomcat.jdbc) tomcat-lib tomcat-docs-webapp: tomcat-docs-webapp tomcat-jsvc: tomcat-jsvc tomcat-systemv: tomcat-systemv tomcat-javadoc: tomcat-javadoc MD5-sum check ------------- http://www.apache.org/dist/tomcat/tomcat-7/v7.0.34/src/apache-tomcat-7.0.34-src.tar.gz : CHECKSUM(SHA256) this package : c05b85928ff870244a061700166ee781e66bad68f4a7867ba22c48beeec19fc0 CHECKSUM(SHA256) upstream package : c05b85928ff870244a061700166ee781e66bad68f4a7867ba22c48beeec19fc0 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn tomcat -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires