Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Old add_to_maven_depmap macro is not being used See: https://fedoraproject.org/wiki/Packaging:Java#add_maven_depmap_macro - Pom files have correct add_maven_depmap call Note: No add_maven_depmap calls found but pom files present See: https://fedoraproject.org/wiki/Packaging:Java#add_maven_depmap_macro - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in tomcat6-admin- webapps, tomcat6-docs-webapp, tomcat6-systemv, tomcat6-lib, tomcat6-webapps See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage - Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java - Javadoc subpackages have Requires: jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tomcat6 -admin-webapps , tomcat6-docs-webapp , tomcat6-javadoc , tomcat6-systemv , tomcat6-lib , tomcat6-webapps [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 4 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Can't find any BUILD directory (--prebuilt option?) [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0 [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: tomcat6-6.0.35-5.fc18.noarch.rpm tomcat6-admin-webapps-6.0.35-5.fc18.noarch.rpm tomcat6-docs-webapp-6.0.35-5.fc18.noarch.rpm tomcat6-javadoc-6.0.35-5.fc18.noarch.rpm tomcat6-systemv-6.0.35-5.fc18.noarch.rpm tomcat6-lib-6.0.35-5.fc18.noarch.rpm tomcat6-webapps-6.0.35-5.fc18.noarch.rpm tomcat6.noarch: W: spelling-error %description -l en_US servlet -> settler tomcat6.noarch: W: non-standard-group Networking/Daemons tomcat6.noarch: W: only-non-binary-in-usr-lib tomcat6.noarch: E: non-standard-dir-perm /etc/tomcat6/Catalina 0775L tomcat6.noarch: W: dangling-symlink /usr/share/tomcat6/lib /usr/share/java/tomcat6 tomcat6.noarch: E: non-standard-dir-perm /var/log/tomcat6 0775L tomcat6.noarch: E: non-standard-dir-perm /var/cache/tomcat6/work 0775L tomcat6.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps 0775L tomcat6.noarch: E: non-standard-dir-perm /usr/share/doc/tomcat6-6.0.35 0775L tomcat6.noarch: E: zero-length /var/log/tomcat6/catalina.out tomcat6.noarch: E: non-standard-dir-perm /var/cache/tomcat6/temp 0775L tomcat6.noarch: E: script-without-shebang /usr/lib/systemd/system/tomcat6.service tomcat6.noarch: E: non-standard-dir-perm /var/cache/tomcat6 0775L tomcat6.noarch: E: non-standard-dir-perm /etc/tomcat6/Catalina/localhost 0775L tomcat6.noarch: E: non-standard-dir-perm /usr/share/tomcat6 0775L tomcat6.noarch: E: non-standard-dir-perm /var/lib/tomcat6 0775L tomcat6.noarch: E: world-writable /etc/tomcat6/web.xml 0666L tomcat6.noarch: E: non-standard-dir-perm /etc/tomcat6 0775L tomcat6.noarch: W: no-manual-page-for-binary tomcat6 tomcat6.noarch: W: no-manual-page-for-binary tomcat6-digest tomcat6.noarch: W: no-manual-page-for-binary tomcat6-sysd tomcat6.noarch: W: no-manual-page-for-binary tomcat6-tool-wrapper tomcat6.noarch: W: dangerous-command-in-%pre cp tomcat6.noarch: W: dangerous-command-in-%posttrans cp tomcat6.noarch: E: use-tmp-in-%posttrans tomcat6-admin-webapps.noarch: W: non-standard-group System Environment/Applications tomcat6-admin-webapps.noarch: W: no-documentation tomcat6-admin-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/manager/WEB-INF/jsp 0775L tomcat6-admin-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/host-manager/META-INF 0775L tomcat6-admin-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/host-manager 0775L tomcat6-admin-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/manager/images 0775L tomcat6-admin-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/host-manager/WEB-INF 0775L tomcat6-admin-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/manager/META-INF 0775L tomcat6-admin-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/host-manager/images 0775L tomcat6-admin-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/manager 0775L tomcat6-admin-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/manager/WEB-INF 0775L tomcat6-docs-webapp.noarch: W: non-standard-group System Environment/Applications tomcat6-docs-webapp.noarch: W: no-documentation tomcat6-systemv.noarch: W: non-standard-group System Environment/Applications tomcat6-systemv.noarch: W: no-documentation tomcat6-systemv.noarch: W: no-manual-page-for-binary tomcat6 tomcat6-systemv.noarch: W: no-manual-page-for-binary dtomcat6 tomcat6-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat6 ${NAME} tomcat6-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat6 ${NAME} tomcat6-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat6 ${NAME} tomcat6-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat6 ${NAME} tomcat6-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat6 ${NAME} tomcat6-systemv.noarch: W: incoherent-subsys /etc/init.d/tomcat6 ${NAME} tomcat6-systemv.noarch: W: incoherent-init-script-name tomcat6 ('tomcat6-systemv', 'tomcat6-systemvd') tomcat6-lib.noarch: W: non-standard-group Development/Compilers tomcat6-lib.noarch: W: no-documentation tomcat6-lib.noarch: W: dangling-symlink /usr/share/java/tomcat6/commons-pool.jar /usr/share/java/apache-commons-pool.jar tomcat6-lib.noarch: W: dangling-relative-symlink /usr/share/java/tomcat6/tomcat6-el-2.1-api.jar ../tomcat6-el-2.1-api.jar tomcat6-lib.noarch: W: dangling-relative-symlink /usr/share/java/tomcat6/tomcat6-servlet-2.5-api.jar ../tomcat6-servlet-2.5-api.jar tomcat6-lib.noarch: W: dangling-symlink /usr/share/java/tomcat6/commons-collections.jar /usr/share/java/apache-commons-collections.jar tomcat6-lib.noarch: W: dangling-symlink /usr/share/java/tomcat6/commons-dbcp.jar /usr/share/java/apache-commons-dbcp.jar tomcat6-lib.noarch: W: dangling-symlink /usr/share/java/tomcat6/jasper-jdt.jar /usr/share/java/ecj.jar tomcat6-lib.noarch: W: dangling-relative-symlink /usr/share/java/tomcat6/tomcat6-jsp-2.1-api.jar ../tomcat6-jsp-2.1-api.jar tomcat6-lib.noarch: W: dangling-symlink /usr/share/java/tomcat6/tomcat-juli.jar /usr/share/tomcat6/bin/tomcat-juli.jar tomcat6-lib.noarch: W: dangling-symlink /usr/share/java/tomcat6/log4j.jar /usr/share/java/log4j.jar tomcat6-webapps.noarch: W: non-standard-group System Environment/Applications tomcat6-webapps.noarch: W: no-documentation tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/xml 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/jsp2 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/util 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/tagplugin 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/plugin 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/filters 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/checkbox 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/servlets 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/error 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/security 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/include 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/servlets/images 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/num 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/sample/WEB-INF/classes 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/jsp/applet 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/snp 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/jsptoserv 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/checkbox 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/colors 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/images 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/jsp2/jspattribute 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/dates 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/error 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/jsp2/tagfiles 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/ROOT/WEB-INF 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/cal 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/compressionFilters 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/chat 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/lib 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/dates 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/jsp2 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/validators 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/chat 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/ROOT 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/tags 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/sample 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/jsp2/jspx 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/cal 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/listeners 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/jsp2/examples 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/forward 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/jsp2 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/sessions 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/colors 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/jsp2/misc 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/sample/WEB-INF 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/jsp 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/examples 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/jsp2/examples/el 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/security/protected 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/plugin/applet 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/sample/WEB-INF/classes/mypackage 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/num 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/WEB-INF 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/jsp2/el 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/sample/images 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/jsp2/simpletag 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/sessions 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/sample/META-INF 0775L tomcat6-webapps.noarch: E: non-standard-dir-perm /var/lib/tomcat6/webapps/examples/jsp/simpletag 0775L 7 packages and 0 specfiles checked; 88 errors, 38 warnings. Requires -------- tomcat6-javadoc (rpmlib, GLIBC filtered): tomcat6-webapps (rpmlib, GLIBC filtered): jakarta-taglibs-standard tomcat6 tomcat6 (rpmlib, GLIBC filtered): /bin/bash /bin/sh chkconfig config(tomcat6) jakarta-commons-collections jakarta-commons-daemon jakarta-commons-dbcp jakarta-commons-logging jakarta-commons-pool java procps redhat-lsb shadow-utils systemd-units tomcat6-lib tomcat6-docs-webapp (rpmlib, GLIBC filtered): tomcat6 tomcat6-lib (rpmlib, GLIBC filtered): coreutils ecj jakarta-commons-collections jakarta-commons-dbcp jakarta-commons-pool tomcat6-el-2.1-api tomcat6-jsp-2.1-api tomcat6-servlet-2.5-api tomcat6-admin-webapps (rpmlib, GLIBC filtered): tomcat6 tomcat6-systemv (rpmlib, GLIBC filtered): /bin/sh chkconfig tomcat6 Provides -------- tomcat6-javadoc: tomcat6-javadoc tomcat6-webapps: tomcat6-webapps tomcat6: config(tomcat6) mvn(org.apache.tomcat:annotations-api) mvn(org.apache.tomcat:catalina) mvn(org.apache.tomcat:catalina-ha) mvn(org.apache.tomcat:el-api) mvn(org.apache.tomcat:jasper) mvn(org.apache.tomcat:jasper-el) mvn(org.apache.tomcat:jsp-api) mvn(org.apache.tomcat:juli) mvn(org.apache.tomcat:servlet-api) mvn(org.apache.tomcat:tribes) tomcat6 tomcat6-log4j tomcat6-docs-webapp: tomcat6-docs-webapp tomcat6-lib: osgi(org.apache.commons.dbcp) tomcat6-lib tomcat6-admin-webapps: tomcat6-admin-webapps tomcat6-systemv: tomcat6-systemv Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn tomcat6 -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires