Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libudisks2 , libudisks2-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 81920 bytes in 5 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define glib2_version 2.31.13 %define gobject_intuirospection_version 1.30.0 %define polkit_version 0.101 %define systemd_version 184 %define libatasmart_version 0.12 %define dbus_version 1.4.0 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 6021120 bytes in /usr/share 5150720 libudisks2-devel-2.0.91-2.fc19.x86_64.rpm 870400 udisks2-2.0.91-2.fc19.x86_64.rpm Rpmlint ------- Checking: udisks2-2.0.91-2.fc19.x86_64.rpm libudisks2-2.0.91-2.fc19.x86_64.rpm libudisks2-devel-2.0.91-2.fc19.x86_64.rpm udisks2.x86_64: W: spelling-error %description -l en_US udisks -> disks, u disks, Saudis udisks2.x86_64: E: non-standard-dir-perm /var/lib/udisks2 0700L udisks2.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.UDisks2.conf udisks2.x86_64: W: no-manual-page-for-binary umount.udisks2 libudisks2.x86_64: W: spelling-error Summary(en_US) udisks -> disks, u disks, Saudis libudisks2.x86_64: W: spelling-error %description -l en_US udisks -> disks, u disks, Saudis libudisks2.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Requires -------- libudisks2 (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) udisks2 (rpmlib, GLIBC filtered): cryptsetup-luks dbus dosfstools e2fsprogs eject gdisk libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libatasmart libatasmart.so.4()(64bit) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgudev-1.0.so.0()(64bit) libpolkit-agent-1.so.0()(64bit) libpolkit-gobject-1.so.0()(64bit) libpthread.so.0()(64bit) libsystemd-daemon.so.0()(64bit) libsystemd-daemon.so.0(LIBSYSTEMD_DAEMON_31)(64bit) libsystemd-login.so.0()(64bit) libsystemd-login.so.0(LIBSYSTEMD_LOGIN_31)(64bit) libudisks2 libudisks2.so.0()(64bit) mdadm mtools ntfsprogs parted rtld(GNU_HASH) systemd util-linux xfsprogs libudisks2-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libudisks2 libudisks2.so.0()(64bit) pkgconfig pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) Provides -------- libudisks2: libudisks2 libudisks2(x86-64) libudisks2.so.0()(64bit) udisks2: udisks2 udisks2(x86-64) libudisks2-devel: libudisks2-devel libudisks2-devel(x86-64) pkgconfig(udisks2) MD5-sum check ------------- http://udisks.freedesktop.org/releases/udisks-2.0.91.tar.bz2 : CHECKSUM(SHA256) this package : 52894a60825f58a8cd490be7d2b0f451943c3efe50a6a06176b0f907d9281cbe CHECKSUM(SHA256) upstream package : 52894a60825f58a8cd490be7d2b0f451943c3efe50a6a06176b0f907d9281cbe Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn udisks2 -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires