Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - No %config files under /usr. Note: %config(noreplace) /usr/lib/udev/rules.d See: http://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libmount , libmount-devel , libblkid , libblkid-devel , libuuid , libuuid-devel , uuidd [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 256000 bytes in 19 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define upstream_version %{version} %define floppyver 0.18 %define cytune_archs %{ix86} alpha %{arm} [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4966400 bytes in /usr/share 30720 libuuid-devel-2.22.2-2.fc19.x86_64.rpm 10240 libmount-2.22.2-2.fc19.x86_64.rpm 10240 libmount- devel-2.22.2-2.fc19.x86_64.rpm 10240 libuuid-2.22.2-2.fc19.x86_64.rpm 4853760 util-linux-2.22.2-2.fc19.x86_64.rpm 30720 uuidd-2.22.2-2.fc19.x86_64.rpm 10240 libblkid-2.22.2-2.fc19.x86_64.rpm 10240 libblkid-devel-2.22.2-2.fc19.x86_64.rpm Rpmlint ------- Checking: util-linux-2.22.2-2.fc19.x86_64.rpm libmount-2.22.2-2.fc19.x86_64.rpm libmount-devel-2.22.2-2.fc19.x86_64.rpm libblkid-2.22.2-2.fc19.x86_64.rpm libblkid-devel-2.22.2-2.fc19.x86_64.rpm libuuid-2.22.2-2.fc19.x86_64.rpm libuuid-devel-2.22.2-2.fc19.x86_64.rpm uuidd-2.22.2-2.fc19.x86_64.rpm util-linux.x86_64: W: only-non-binary-in-usr-lib util-linux.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/lib/udev/rules.d/60-raw.rules util-linux.x86_64: E: setuid-binary /usr/bin/mount root 04755L util-linux.x86_64: E: non-standard-executable-perm /usr/bin/mount 04755L util-linux.x86_64: E: setuid-binary /usr/bin/chsh root 04711L util-linux.x86_64: E: non-standard-executable-perm /usr/bin/chsh 04711L util-linux.x86_64: E: non-standard-executable-perm /usr/bin/chsh 04711L util-linux.x86_64: W: manual-page-warning /usr/share/man/man1/col.1.gz 78: warning: macro `It' not defined util-linux.x86_64: W: manual-page-warning /usr/share/man/man8/floppy.8.gz 172: warning: macro `HTML-TAG' not defined util-linux.x86_64: W: manual-page-warning /usr/share/man/man8/floppy.8.gz 172: warning: macro `"' not defined util-linux.x86_64: W: dangling-symlink /etc/mtab /proc/mounts util-linux.x86_64: E: setuid-binary /usr/bin/chfn root 04711L util-linux.x86_64: E: non-standard-executable-perm /usr/bin/chfn 04711L util-linux.x86_64: E: non-standard-executable-perm /usr/bin/chfn 04711L util-linux.x86_64: E: setuid-binary /usr/bin/su root 04755L util-linux.x86_64: E: non-standard-executable-perm /usr/bin/su 04755L util-linux.x86_64: W: manual-page-warning /usr/share/man/man1/ul.1.gz 66: warning: macro `It' not defined util-linux.x86_64: E: setgid-binary /usr/bin/write tty 02755L util-linux.x86_64: E: non-standard-executable-perm /usr/bin/write 02755L util-linux.x86_64: E: setuid-binary /usr/bin/umount root 04755L util-linux.x86_64: E: non-standard-executable-perm /usr/bin/umount 04755L util-linux.x86_64: W: manual-page-warning /usr/share/man/man1/more.1.gz 60: warning: macro `It' not defined util-linux.x86_64: W: log-files-without-logrotate /var/log/lastlog util-linux.x86_64: W: no-manual-page-for-binary mkfs.cramfs util-linux.x86_64: W: no-manual-page-for-binary fsck.cramfs util-linux.x86_64: W: dangerous-command-in-%post chown util-linux.x86_64: E: forbidden-selinux-command-in-%post chcon libmount.x86_64: W: spelling-error %description -l en_US util -> til, until, u til libmount.x86_64: W: spelling-error %description -l en_US linux -> Linux libmount-devel.x86_64: W: spelling-error %description -l en_US util -> til, until, u til libmount-devel.x86_64: W: spelling-error %description -l en_US linux -> Linux libblkid.x86_64: W: spelling-error %description -l en_US util -> til, until, u til libblkid.x86_64: W: spelling-error %description -l en_US linux -> Linux libblkid.x86_64: W: dangerous-command-in-%post mv libblkid-devel.x86_64: W: spelling-error %description -l en_US util -> til, until, u til libblkid-devel.x86_64: W: spelling-error %description -l en_US linux -> Linux libuuid.x86_64: W: spelling-error %description -l en_US util -> til, until, u til libuuid.x86_64: W: spelling-error %description -l en_US linux -> Linux libuuid.x86_64: W: spelling-error %description -l en_US uuid -> quid libuuid-devel.x86_64: W: spelling-error %description -l en_US util -> til, until, u til libuuid-devel.x86_64: W: spelling-error %description -l en_US linux -> Linux uuidd.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace uuidd.x86_64: W: only-non-binary-in-usr-lib uuidd.x86_64: W: non-standard-uid /usr/sbin/uuidd uuidd uuidd.x86_64: W: non-standard-gid /usr/sbin/uuidd uuidd uuidd.x86_64: W: non-standard-uid /run/uuidd uuidd uuidd.x86_64: W: non-standard-gid /run/uuidd uuidd uuidd.x86_64: E: non-standard-dir-perm /run/uuidd 02775L uuidd.x86_64: W: non-standard-uid /var/lib/libuuid uuidd uuidd.x86_64: W: non-standard-gid /var/lib/libuuid uuidd uuidd.x86_64: E: non-standard-dir-perm /var/lib/libuuid 02775L 8 packages and 0 specfiles checked; 17 errors, 34 warnings. Requires -------- uuidd (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) librt.so.1()(64bit) libuuid libuuid.so.1()(64bit) libuuid.so.1(UUIDD_PRIVATE)(64bit) libuuid.so.1(UUID_1.0)(64bit) rtld(GNU_HASH) shadow-utils libmount-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libmount libmount.so.1()(64bit) pkgconfig pkgconfig(blkid) libblkid (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig coreutils ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libuuid libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) rtld(GNU_HASH) libuuid (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) libmount (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libblkid libblkid.so.1()(64bit) libblkid.so.1(BLKID_1.0)(64bit) libblkid.so.1(BLKID_2.15)(64bit) libblkid.so.1(BLKID_2.17)(64bit) libc.so.6()(64bit) libselinux.so.1()(64bit) libsepol.so.1()(64bit) libuuid.so.1()(64bit) rtld(GNU_HASH) util-linux (rpmlib, GLIBC filtered): /bin/sh /etc/pam.d/system-auth audit-libs config(util-linux) coreutils ld-linux-x86-64.so.2()(64bit) libaudit.so.1()(64bit) libblkid libblkid.so.1()(64bit) libblkid.so.1(BLKID_1.0)(64bit) libblkid.so.1(BLKID_2.15)(64bit) libblkid.so.1(BLKID_2.17)(64bit) libblkid.so.1(BLKID_2.18)(64bit) libblkid.so.1(BLKID_2.20)(64bit) libblkid.so.1(BLKID_2.21)(64bit) libc.so.6()(64bit) libcrypt.so.1()(64bit) libmount libmount.so.1()(64bit) libmount.so.1(MOUNT_2.19)(64bit) libmount.so.1(MOUNT_2.20)(64bit) libmount.so.1(MOUNT_2.21)(64bit) libmount.so.1(MOUNT_2.22)(64bit) libncursesw.so.5()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpam_misc.so.0()(64bit) libpam_misc.so.0(LIBPAM_MISC_1.0)(64bit) libpopt.so.0()(64bit) libpopt.so.0(LIBPOPT_0)(64bit) libselinux.so.1()(64bit) libsepol.so.1()(64bit) libtinfo.so.5()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libutempter.so.0()(64bit) libutempter.so.0(UTEMPTER_1.1)(64bit) libutil.so.1()(64bit) libuuid libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libz.so.1()(64bit) pam rtld(GNU_HASH) systemd systemd-units libuuid-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libuuid libuuid.so.1()(64bit) pkgconfig libblkid-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libblkid libblkid.so.1()(64bit) pkgconfig pkgconfig(uuid) Provides -------- uuidd: uuidd uuidd(x86-64) libmount-devel: libmount-devel libmount-devel(x86-64) pkgconfig(mount) libblkid: libblkid libblkid(x86-64) libblkid.so.1()(64bit) libblkid.so.1(BLKID_1.0)(64bit) libblkid.so.1(BLKID_2.15)(64bit) libblkid.so.1(BLKID_2.17)(64bit) libblkid.so.1(BLKID_2.18)(64bit) libblkid.so.1(BLKID_2.20)(64bit) libblkid.so.1(BLKID_2.21)(64bit) libuuid: libuuid libuuid(x86-64) libuuid.so.1()(64bit) libuuid.so.1(UUIDD_PRIVATE)(64bit) libuuid.so.1(UUID_1.0)(64bit) libuuid.so.1(UUID_2.20)(64bit) libmount: libmount libmount(x86-64) libmount.so.1()(64bit) libmount.so.1(MOUNT_2.19)(64bit) libmount.so.1(MOUNT_2.20)(64bit) libmount.so.1(MOUNT_2.21)(64bit) libmount.so.1(MOUNT_2.22)(64bit) util-linux: /bin/dmesg /bin/kill /bin/more /bin/mount /bin/umount /sbin/blkid /sbin/blockdev /sbin/findfs /sbin/fsck /sbin/nologin config(util-linux) eject util-linux util-linux(x86-64) util-linux-ng libuuid-devel: libuuid-devel libuuid-devel(x86-64) pkgconfig(uuid) libblkid-devel: libblkid-devel libblkid-devel(x86-64) pkgconfig(blkid) MD5-sum check ------------- http://downloads.sourceforge.net/floppyutil/floppy-0.18.tar.bz2 : CHECKSUM(SHA256) this package : 00cc174dc811478987e372aaa6d107bce24701db99cb898c1f462764389f060b CHECKSUM(SHA256) upstream package : 00cc174dc811478987e372aaa6d107bce24701db99cb898c1f462764389f060b ftp://ftp.kernel.org/pub/linux/utils/util-linux/v2.22/util-linux-2.22.2.tar.xz : CHECKSUM(SHA256) this package : 929b517fa39b16a61ec536514e08940a381b92befc629d0348e3097920dd2f12 CHECKSUM(SHA256) upstream package : 929b517fa39b16a61ec536514e08940a381b92befc629d0348e3097920dd2f12 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn util-linux -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires