Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Static libraries in -static subpackage, if present. Note: Archive *.a files found in valgrind-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries - Large documentation must go in a -doc subpackage. Note: Documentation size is 2621440 bytes in 50 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in valgrind- devel , valgrind-openmpi [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define valarch x86 %define valsecarch %{nil} %define valarch amd64 %define valsecarch x86 %define valarch ppc32 %define valsecarch ppc64 %define valarch ppc64 %define valsecarch ppc32 %define valarch s390x %define valsecarch %{nil} %define valarch armv7hl %define valsecarch %{nil} %define valarch armv5tel %define valsecarch %{nil} %define __spec_install_post /usr/lib/rpm/brp-compress || : %define debug_package %{nil} %define mpiccpath %{!?scl:%{_libdir}}%{?scl:%{_root_libdir}}/openmpi/bin/mpicc %define mpiccpath %{!?scl:%{_libdir}}%{?scl:%{_root_libdir}}/openmpi/*/bin/mpicc [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2662400 bytes in /usr/share 2662400 valgrind-3.8.1-6.fc19.x86_64.rpm Rpmlint ------- Checking: valgrind-3.8.1-6.fc19.x86_64.rpm valgrind-devel-3.8.1-6.fc19.x86_64.rpm valgrind-openmpi-3.8.1-6.fc19.x86_64.rpm valgrind.x86_64: W: spelling-error %description -l en_US malloc -> mallow valgrind.x86_64: W: incoherent-version-in-changelog 3.8.1-6 ['1:3.8.1-6.fc19', '1:3.8.1-6'] valgrind.x86_64: W: obsolete-not-provided valgrind-callgrind valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/none-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/none-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/memcheck-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/memcheck-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_exp-sgcheck-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_exp-sgcheck-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/bin/valgrind-listener valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/cachegrind-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/cachegrind-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_drd-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_drd-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/exp-bbv-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/exp-bbv-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/bin/vgdb valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/drd-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/drd-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/lackey-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/lackey-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_massif-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_massif-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_exp-dhat-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_exp-dhat-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/bin/valgrind valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/exp-sgcheck-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/exp-sgcheck-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/bin/cg_merge valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/massif-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/massif-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_core-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_core-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/callgrind-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/callgrind-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/exp-dhat-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/exp-dhat-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/helgrind-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/helgrind-amd64-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/cachegrind-x86-linux ../../lib/valgrind/cachegrind-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/exp-sgcheck-x86-linux ../../lib/valgrind/exp-sgcheck-x86-linux valgrind.x86_64: E: incorrect-fsf-address /usr/share/doc/valgrind-3.8.1/COPYING valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_massif-x86-linux.so ../../lib/valgrind/vgpreload_massif-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_core-x86-linux.so ../../lib/valgrind/vgpreload_core-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/helgrind-x86-linux ../../lib/valgrind/helgrind-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/callgrind-x86-linux ../../lib/valgrind/callgrind-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/memcheck-x86-linux ../../lib/valgrind/memcheck-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_memcheck-x86-linux.so ../../lib/valgrind/vgpreload_memcheck-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/massif-x86-linux ../../lib/valgrind/massif-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_helgrind-x86-linux.so ../../lib/valgrind/vgpreload_helgrind-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_exp-dhat-x86-linux.so ../../lib/valgrind/vgpreload_exp-dhat-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_drd-x86-linux.so ../../lib/valgrind/vgpreload_drd-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/exp-dhat-x86-linux ../../lib/valgrind/exp-dhat-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/lackey-x86-linux ../../lib/valgrind/lackey-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/exp-bbv-x86-linux ../../lib/valgrind/exp-bbv-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_exp-sgcheck-x86-linux.so ../../lib/valgrind/vgpreload_exp-sgcheck-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/drd-x86-linux ../../lib/valgrind/drd-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/none-x86-linux ../../lib/valgrind/none-x86-linux valgrind.x86_64: W: no-manual-page-for-binary vgdb valgrind.x86_64: W: no-manual-page-for-binary cg_diff valgrind.x86_64: W: no-manual-page-for-binary valgrind-listener valgrind.x86_64: W: no-manual-page-for-binary cg_merge valgrind-devel.x86_64: W: no-documentation valgrind-devel.x86_64: E: incorrect-fsf-address /usr/include/valgrind/vki/vki-s390x-linux.h valgrind-devel.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/libreplacemalloc_toolpreload-x86-linux.a ../../lib/valgrind/libreplacemalloc_toolpreload-x86-linux.a valgrind-devel.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/libvex-x86-linux.a ../../lib/valgrind/libvex-x86-linux.a valgrind-devel.x86_64: E: incorrect-fsf-address /usr/include/valgrind/libvex_guest_mips32.h valgrind-devel.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/libcoregrind-x86-linux.a ../../lib/valgrind/libcoregrind-x86-linux.a valgrind-devel.x86_64: E: incorrect-fsf-address /usr/include/valgrind/pub_tool_libcsetjmp.h valgrind-devel.x86_64: E: incorrect-fsf-address /usr/include/valgrind/pub_tool_gdbserver.h valgrind-openmpi.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/libmpiwrap-amd64-linux.so valgrind-openmpi.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 23 errors, 53 warnings. Requires -------- valgrind-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config valgrind valgrind-openmpi (rpmlib, GLIBC filtered): libc.so.6()(64bit) libmpi.so.1()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) valgrind valgrind (rpmlib, GLIBC filtered): /usr/bin/perl libc.so.6()(64bit) libpthread.so.0()(64bit) perl(strict) perl(warnings) rtld(GNU_HASH) Provides -------- valgrind-devel: pkgconfig(valgrind) valgrind-devel valgrind-devel(x86-64) valgrind-openmpi: libmpiwrap-amd64-linux.so()(64bit) valgrind-openmpi valgrind-openmpi(x86-64) valgrind: valgrind valgrind(x86-64) vgpreload_core-amd64-linux.so()(64bit) vgpreload_drd-amd64-linux.so()(64bit) vgpreload_exp-dhat-amd64-linux.so()(64bit) vgpreload_exp-sgcheck-amd64-linux.so()(64bit) vgpreload_helgrind-amd64-linux.so()(64bit) vgpreload_massif-amd64-linux.so()(64bit) vgpreload_memcheck-amd64-linux.so()(64bit) Unversioned so-files -------------------- valgrind: /usr/lib64/valgrind/vgpreload_core-amd64-linux.so valgrind: /usr/lib64/valgrind/vgpreload_core-x86-linux.so valgrind: /usr/lib64/valgrind/vgpreload_drd-amd64-linux.so valgrind: /usr/lib64/valgrind/vgpreload_drd-x86-linux.so valgrind: /usr/lib64/valgrind/vgpreload_exp-dhat-amd64-linux.so valgrind: /usr/lib64/valgrind/vgpreload_exp-dhat-x86-linux.so valgrind: /usr/lib64/valgrind/vgpreload_exp-sgcheck-amd64-linux.so valgrind: /usr/lib64/valgrind/vgpreload_exp-sgcheck-x86-linux.so valgrind: /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so valgrind: /usr/lib64/valgrind/vgpreload_helgrind-x86-linux.so valgrind: /usr/lib64/valgrind/vgpreload_massif-amd64-linux.so valgrind: /usr/lib64/valgrind/vgpreload_massif-x86-linux.so valgrind: /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so valgrind: /usr/lib64/valgrind/vgpreload_memcheck-x86-linux.so valgrind-openmpi: /usr/lib64/valgrind/libmpiwrap-amd64-linux.so valgrind-openmpi: /usr/lib64/valgrind/libmpiwrap-x86-linux.so MD5-sum check ------------- http://www.valgrind.org/downloads/valgrind-3.8.1.tar.bz2 : CHECKSUM(SHA256) this package : 473be00576bed311a662b277a2bfbe97d9cca4058e68619a0e420c9fc19958db CHECKSUM(SHA256) upstream package : 473be00576bed311a662b277a2bfbe97d9cca4058e68619a0e420c9fc19958db Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn valgrind -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires