Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vdsm-cli , vdsm-xmlrpc , vdsm-rest , vdsm-bootstrap , vdsm-reg , vdsm-python , vdsm- debug-plugin , vdsm-tests , vdsm-hook-vhostmd , vdsm-hook-faqemu , vdsm- hook-directlun , vdsm-hook-fileinject , vdsm-hook-floppy , vdsm-hook- hostusb , vdsm-hook-hugepages , vdsm-hook-isolatedprivatevlan , vdsm- hook-numa , vdsm-hook-pincpu , vdsm-hook-promisc , vdsm-hook-qos , vdsm- hook-scratchpad , vdsm-hook-smartcard , vdsm-hook-smbios , vdsm-hook- sriov , vdsm-hook-vmdisk , vdsm-gluster [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 215040 bytes in 9 files. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Dist tag is present. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %{!?enable_autotools:%define enable_autotools 1} [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2519040 bytes in /usr/share 2519040 vdsm-4.10.0-11.fc19.x86_64.rpm Rpmlint ------- Checking: vdsm-4.10.0-11.fc19.x86_64.rpm vdsm-cli-4.10.0-11.fc19.noarch.rpm vdsm-xmlrpc-4.10.0-11.fc19.noarch.rpm vdsm-rest-4.10.0-11.fc19.noarch.rpm vdsm-bootstrap-4.10.0-11.fc19.noarch.rpm vdsm-reg-4.10.0-11.fc19.noarch.rpm vdsm-python-4.10.0-11.fc19.x86_64.rpm vdsm-debug-plugin-4.10.0-11.fc19.noarch.rpm vdsm-tests-4.10.0-11.fc19.noarch.rpm vdsm-hook-vhostmd-4.10.0-11.fc19.noarch.rpm vdsm-hook-faqemu-4.10.0-11.fc19.noarch.rpm vdsm-hook-directlun-4.10.0-11.fc19.noarch.rpm vdsm-hook-fileinject-4.10.0-11.fc19.noarch.rpm vdsm-hook-floppy-4.10.0-11.fc19.noarch.rpm vdsm-hook-hostusb-4.10.0-11.fc19.noarch.rpm vdsm-hook-hugepages-4.10.0-11.fc19.noarch.rpm vdsm-hook-isolatedprivatevlan-4.10.0-11.fc19.noarch.rpm vdsm-hook-numa-4.10.0-11.fc19.noarch.rpm vdsm-hook-pincpu-4.10.0-11.fc19.noarch.rpm vdsm-hook-promisc-4.10.0-11.fc19.noarch.rpm vdsm-hook-qos-4.10.0-11.fc19.noarch.rpm vdsm-hook-scratchpad-4.10.0-11.fc19.noarch.rpm vdsm-hook-smartcard-4.10.0-11.fc19.noarch.rpm vdsm-hook-smbios-4.10.0-11.fc19.noarch.rpm vdsm-hook-sriov-4.10.0-11.fc19.noarch.rpm vdsm-hook-vmdisk-4.10.0-11.fc19.noarch.rpm vdsm-gluster-4.10.0-11.fc19.noarch.rpm vdsm.x86_64: E: explicit-lib-dependency libvirt-lock-sanlock vdsm.x86_64: E: non-standard-dir-perm /var/lib/libvirt/qemu/channels 0775L vdsm.x86_64: E: non-readable /etc/sudoers.d/50_vdsm 0440L vdsm.x86_64: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm vdsm.x86_64: E: non-readable /etc/pki/vdsm/keys/libvirt_password 0600L vdsm.x86_64: W: non-conffile-in-etc /etc/cron.d/vdsm-libvirt-logrotate vdsm.x86_64: W: non-conffile-in-etc /etc/security/limits.d/99-vdsm.conf vdsm-cli.noarch: W: non-conffile-in-etc /etc/bash_completion.d/vdsClient vdsm-xmlrpc.noarch: W: spelling-error %description -l en_US vdsmd vdsm-xmlrpc.noarch: W: spelling-error %description -l en_US ovirt -> overt vdsm-xmlrpc.noarch: W: spelling-error %description -l en_US vdsClient -> clientele vdsm-xmlrpc.noarch: W: no-documentation vdsm-rest.noarch: W: spelling-error %description -l en_US vdsmd vdsm-rest.noarch: W: no-documentation vdsm-reg.noarch: E: non-standard-dir-perm /data/updates 0775L vdsm-reg.noarch: W: non-conffile-in-etc /etc/ovirt-commandline.d/vdsm-reg vdsm-python.x86_64: W: spelling-error %description -l en_US beween -> between, be ween, be-ween vdsm-python.x86_64: W: unstripped-binary-or-object /usr/lib/python2.7/site-packages/vdsm/betterPopen/createprocess.so vdsm-python.x86_64: W: no-documentation vdsm-python.x86_64: W: no-manual-page-for-binary vdsm-tool vdsm-debug-plugin.noarch: W: no-documentation vdsm-tests.noarch: E: non-executable-script /usr/share/vdsm/tests/alignmentScanTests.py 0644L /usr/bin/python vdsm-hook-vhostmd.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_vhostmd 0440L vdsm-hook-vhostmd.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_vhostmd vdsm-hook-faqemu.noarch: W: spelling-error Summary(en_US) qemu -> emu, q emu vdsm-hook-directlun.noarch: W: no-documentation vdsm-hook-directlun.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_directlun 0440L vdsm-hook-directlun.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_directlun vdsm-hook-fileinject.noarch: W: no-documentation vdsm-hook-floppy.noarch: W: no-documentation vdsm-hook-hostusb.noarch: W: no-documentation vdsm-hook-hostusb.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_hostusb 0440L vdsm-hook-hostusb.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_hostusb vdsm-hook-hugepages.noarch: W: summary-ended-with-dot C Huge pages enable user to handle VM with 2048KB page files. vdsm-hook-hugepages.noarch: W: no-documentation vdsm-hook-hugepages.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_hugepages 0440L vdsm-hook-hugepages.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_hugepages vdsm-hook-isolatedprivatevlan.noarch: W: spelling-error %description -l en_US ip -> pi, up, op vdsm-hook-isolatedprivatevlan.noarch: W: spelling-error %description -l en_US filterref -> filter ref, filter-ref, filterer vdsm-hook-isolatedprivatevlan.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml vdsm-hook-isolatedprivatevlan.noarch: W: no-documentation vdsm-hook-isolatedprivatevlan.noarch: E: executable-marked-as-config-file /etc/libvirt/nwfilter/isolatedprivatevlan-vdsm.xml vdsm-hook-isolatedprivatevlan.noarch: E: script-without-shebang /etc/libvirt/nwfilter/isolatedprivatevlan-vdsm.xml vdsm-hook-numa.noarch: W: spelling-error Summary(en_US) sopport -> support, sop port, sop-port vdsm-hook-numa.noarch: W: summary-not-capitalized C numa sopport for VDSM vdsm-hook-numa.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml vdsm-hook-numa.noarch: W: no-documentation vdsm-hook-pincpu.noarch: W: no-documentation vdsm-hook-promisc.noarch: W: no-documentation vdsm-hook-promisc.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_promisc 0440L vdsm-hook-promisc.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_promisc vdsm-hook-qos.noarch: W: no-documentation vdsm-hook-scratchpad.noarch: W: no-documentation vdsm-hook-smartcard.noarch: W: no-documentation vdsm-hook-smbios.noarch: W: spelling-error Summary(en_US) libvirt -> liberty vdsm-hook-smbios.noarch: W: spelling-error %description -l en_US libvirt -> liberty vdsm-hook-smbios.noarch: W: no-documentation vdsm-hook-sriov.noarch: W: spelling-error Summary(en_US) sr -> cir, rs, Sr vdsm-hook-sriov.noarch: W: spelling-error Summary(en_US) iov -> iv, ion, gov vdsm-hook-sriov.noarch: W: summary-not-capitalized C sr-iov support for VDSM vdsm-hook-sriov.noarch: W: spelling-error %description -l en_US sr -> cir, rs, Sr vdsm-hook-sriov.noarch: W: spelling-error %description -l en_US iov -> iv, ion, gov vdsm-hook-sriov.noarch: W: no-documentation vdsm-hook-sriov.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_sriov 0440L vdsm-hook-sriov.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_sriov vdsm-hook-vmdisk.noarch: W: no-documentation vdsm-gluster.noarch: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist 27 packages and 0 specfiles checked; 14 errors, 53 warnings. Requires -------- vdsm-hook-promisc (rpmlib, GLIBC filtered): /usr/bin/python vdsm-hook-fileinject (rpmlib, GLIBC filtered): /usr/bin/python vdsm-gluster (rpmlib, GLIBC filtered): glusterfs glusterfs-fuse glusterfs-server vdsm vdsm-hook-hugepages (rpmlib, GLIBC filtered): /usr/bin/python vdsm (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/python /usr/sbin/saslpasswd2 bridge-utils config(vdsm) device-mapper-multipath dmidecode dosfstools e2fsprogs fence-agents iscsi-initiator-utils kernel libc.so.6()(64bit) libselinux-python libvirt libvirt-lock-sanlock libvirt-python logrotate lvm2 nfs-utils ntp policycoreutils-python psmisc pyparted python python(abi) python-ethtool qemu-img qemu-kvm rtld(GNU_HASH) sanlock sanlock-python selinux-policy-targeted sos sudo tree vdsm-python which xz vdsm-cli (rpmlib, GLIBC filtered): /bin/sh vdsm-python vdsm-xmlrpc vdsm-hook-scratchpad (rpmlib, GLIBC filtered): /usr/bin/python vdsm-debug-plugin (rpmlib, GLIBC filtered): vdsm vdsm-xmlrpc vdsm-reg (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/python config(vdsm-reg) python(abi) traceroute vdsm vdsm-hook-faqemu (rpmlib, GLIBC filtered): /usr/bin/python vdsm-xmlrpc (rpmlib, GLIBC filtered): vdsm-python vdsm-hook-pincpu (rpmlib, GLIBC filtered): /usr/bin/python vdsm-hook-isolatedprivatevlan (rpmlib, GLIBC filtered): /usr/bin/python config(vdsm-hook-isolatedprivatevlan) vdsm-rest (rpmlib, GLIBC filtered): python-cheetah python-cherrypy vdsm-python vdsm-hook-sriov (rpmlib, GLIBC filtered): /usr/bin/python vdsm-tests (rpmlib, GLIBC filtered): /bin/sh vdsm vdsm-hook-vhostmd (rpmlib, GLIBC filtered): /usr/bin/python vhostmd vdsm-hook-qos (rpmlib, GLIBC filtered): /usr/bin/python vdsm-hook-floppy (rpmlib, GLIBC filtered): /usr/bin/python vdsm-hook-vmdisk (rpmlib, GLIBC filtered): /usr/bin/python vdsm-hook-hostusb (rpmlib, GLIBC filtered): /usr/bin/python vdsm-hook-numa (rpmlib, GLIBC filtered): /usr/bin/python vdsm-bootstrap (rpmlib, GLIBC filtered): /usr/bin/python vdsm-hook-smartcard (rpmlib, GLIBC filtered): /usr/bin/python vdsm-hook-directlun (rpmlib, GLIBC filtered): /usr/bin/python vdsm-python (rpmlib, GLIBC filtered): /usr/bin/python config(vdsm-python) python(abi) vdsm-hook-smbios (rpmlib, GLIBC filtered): /usr/bin/python Provides -------- vdsm-hook-promisc: vdsm-hook-promisc vdsm-hook-fileinject: vdsm-hook-fileinject vdsm-gluster: vdsm-gluster vdsm-hook-hugepages: vdsm-hook-hugepages vdsm: config(vdsm) vdsm vdsm(x86-64) vdsm-cli: vdsm-cli vdsm-hook-scratchpad: vdsm-hook-scratchpad vdsm-debug-plugin: vdsm-debug-plugin vdsm-reg: config(vdsm-reg) vdsm-reg vdsm-hook-faqemu: vdsm-hook-faqemu vdsm-xmlrpc: vdsm-xmlrpc vdsm-hook-pincpu: vdsm-hook-pincpu vdsm-hook-isolatedprivatevlan: config(vdsm-hook-isolatedprivatevlan) vdsm-hook-isolatedprivatevlan vdsm-rest: vdsm-rest vdsm-hook-sriov: vdsm-hook-sriov vdsm-tests: vdsm-tests vdsm-hook-vhostmd: vdsm-hook-vhostmd vdsm-hook-qos: vdsm-hook-qos vdsm-hook-floppy: vdsm-hook-floppy vdsm-hook-vmdisk: vdsm-hook-vmdisk vdsm-hook-hostusb: vdsm-hook-hostusb vdsm-hook-numa: vdsm-hook-numa vdsm-bootstrap: vdsm-bootstrap vdsm-hook-smartcard: vdsm-hook-smartcard vdsm-hook-directlun: vdsm-hook-directlun vdsm-python: config(vdsm-python) vdsm-python vdsm-python(x86-64) vdsm-hook-smbios: vdsm-hook-smbios Unversioned so-files -------------------- vdsm-python: /usr/lib/python2.7/site-packages/vdsm/betterPopen/createprocess.so Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn vdsm -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires