Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains the mandatory BuildRequires and Requires:. Note: Explicit dependency on perl-devel is not allowed See: http://fedoraproject.org/wiki/Packaging:Perl - gtk-update-icon-cache is invoked when required Note: icons in vim-X11 See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - update-desktop-database is invoked when required Note: desktop file(s) in vim-X11 See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vim-common , vim-minimal , vim-enhanced , vim-filesystem , vim-X11 [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 122880 bytes in 19 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source5 [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define CVSDATE %{nil} %define WITH_SELINUX 1 %define desktop_file 1 %define desktop_file_utils_version 0.2.93 %define withnetbeans 1 %define withvimspell 0 %define withhunspell 0 %define withruby 1 %define baseversion 7.3 %define beta %{nil} %define vimdir vim73%{?beta} %define patchlevel 785 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 21463040 bytes in /usr/share 40960 vim-X11-7.3.785-1.fc19.x86_64.rpm 20480 vim- filesystem-7.3.785-1.fc19.x86_64.rpm 21391360 vim- common-7.3.785-1.fc19.x86_64.rpm 10240 vim- enhanced-7.3.785-1.fc19.x86_64.rpm Rpmlint ------- Checking: vim-common-7.3.785-1.fc19.x86_64.rpm vim-minimal-7.3.785-1.fc19.x86_64.rpm vim-enhanced-7.3.785-1.fc19.x86_64.rpm vim-filesystem-7.3.785-1.fc19.x86_64.rpm vim-X11-7.3.785-1.fc19.x86_64.rpm vim-common.x86_64: W: spelling-error %description -l en_US iMproved -> improved, improves, improve vim-common.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti vim-minimal.x86_64: W: spelling-error %description -l en_US iMproved -> improved, improves, improve vim-minimal.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti vim-minimal.x86_64: W: no-documentation vim-minimal.x86_64: W: no-manual-page-for-binary rview vim-minimal.x86_64: W: no-manual-page-for-binary vi vim-minimal.x86_64: W: no-manual-page-for-binary rvi vim-minimal.x86_64: W: no-manual-page-for-binary ex vim-minimal.x86_64: W: no-manual-page-for-binary view vim-enhanced.x86_64: W: spelling-error %description -l en_US iMproved -> improved, improves, improve vim-enhanced.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti vim-enhanced.x86_64: W: no-manual-page-for-binary vim vim-filesystem.x86_64: W: spelling-error %description -l en_US filetypes -> file types, file-types, teletypes vim-filesystem.x86_64: W: no-documentation vim-X11.x86_64: W: spelling-error %description -l en_US iMproved -> improved, improves, improve vim-X11.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti vim-X11.x86_64: W: no-manual-page-for-binary gvimtutor vim-X11.x86_64: W: no-manual-page-for-binary gex vim-X11.x86_64: W: no-manual-page-for-binary vimx vim-X11.x86_64: W: no-manual-page-for-binary gview 5 packages and 0 specfiles checked; 0 errors, 21 warnings. Requires -------- vim-minimal (rpmlib, GLIBC filtered): config(vim-minimal) libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libc.so.6()(64bit) libselinux.so.1()(64bit) libtinfo.so.5()(64bit) rtld(GNU_HASH) vim-filesystem (rpmlib, GLIBC filtered): vim-common (rpmlib, GLIBC filtered): /bin/sh config(vim-common) libc.so.6()(64bit) rtld(GNU_HASH) vim-filesystem vim-X11 (rpmlib, GLIBC filtered): /bin/sh gtk2 hicolor-icon-theme libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXt.so.6()(64bit) libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libattr libc.so.6()(64bit) libdl.so.2()(64bit) libgpm.so.2()(64bit) libm.so.6()(64bit) libperl.so()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libtinfo.so.5()(64bit) perl(:MODULE_COMPAT_5.16.2) rtld(GNU_HASH) vim-common vim-enhanced (rpmlib, GLIBC filtered): /bin/sh config(vim-enhanced) libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgpm.so.2()(64bit) libm.so.6()(64bit) libperl.so()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libtinfo.so.5()(64bit) perl(:MODULE_COMPAT_5.16.2) rtld(GNU_HASH) vim-common which Provides -------- vim-minimal: /bin/vi config(vim-minimal) vi vim-minimal vim-minimal(x86-64) vim-filesystem: vim-filesystem vim-filesystem(x86-64) vim-common: config(vim-common) vim-common vim-common(x86-64) vim-X11: gvim mimehandler(application/x-shellscript) mimehandler(text/english) mimehandler(text/plain) mimehandler(text/x-c) mimehandler(text/x-c++) mimehandler(text/x-c++hdr) mimehandler(text/x-c++src) mimehandler(text/x-chdr) mimehandler(text/x-csrc) mimehandler(text/x-java) mimehandler(text/x-makefile) mimehandler(text/x-moc) mimehandler(text/x-pascal) mimehandler(text/x-tcl) mimehandler(text/x-tex) vim-X11 vim-X11(x86-64) vim-enhanced: config(vim-enhanced) vim vim-enhanced vim-enhanced(x86-64) MD5-sum check ------------- ftp://ftp.vim.org/pub/vim/unix/vim-7.3.tar.bz2 : CHECKSUM(SHA256) this package : 5c5d5d6e07f1bbc49b6fe3906ff8a7e39b049928b68195b38e3e3d347100221d CHECKSUM(SHA256) upstream package : 5c5d5d6e07f1bbc49b6fe3906ff8a7e39b049928b68195b38e3e3d347100221d Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn vim -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires