Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - GConf schemas are properly installed Note: gconf file(s) in virt-manager See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GConf - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - update-desktop-database is invoked when required Note: desktop file(s) in virt-manager See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in virt- manager-tui [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in virt-manager [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 71680 bytes in 6 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Dist tag is present. [!]: Spec use %global instead of %define. Note: %define _package virt-manager %define _version 0.9.4 %define _release 4 %define virtinst_version 0.600.3 %define qemu_user "qemu" %define preferred_distros "fedora,rhel" %define kvm_packages "qemu- system-x86" %define libvirt_packages "libvirt-daemon-qemu" %define askpass_package "openssh-askpass" %define disable_unsupported_rhel 0 %define with_guestfs 0 %define with_tui 1 %define with_spice 1 %define default_graphics "spice" %define _extra_release %{?dist:%{dist}}%{?extra_release:%{extra_release}} %define verrel %{version}-%{release} %define _qemu_user --with-qemu_user=%{qemu_user} %define _kvm_packages --with-kvm-packages=%{kvm_packages} %define _preferred_distros --with-preferred-distros=%{preferred_distros} %define _libvirt_packages --with-libvirt-package-names=%{libvirt_packages} %define _askpass_package --with-askpass-package=%{askpass_package} %define _disable_unsupported_rhel --disable-unsupported-rhel-options %define _default_graphics --with-default-graphics=%{default_graphics} %define _tui_opt --with-tui %define _tui_opt --without-tui [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: virt-manager-0.9.4-4.fc19.noarch.rpm virt-manager-tui-0.9.4-4.fc19.noarch.rpm virt-manager.noarch: E: explicit-lib-dependency libgnome-keyring virt-manager.noarch: W: spelling-error %description -l en_US libvirt -> liberty virt-manager.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end virt-manager.noarch: W: non-conffile-in-etc /etc/gconf/schemas/virt-manager.schemas virt-manager.noarch: E: incorrect-fsf-address /usr/share/doc/virt-manager-0.9.4/COPYING-DOCS virt-manager.noarch: W: dangerous-command-in-%pre rm virt-manager.noarch: W: dangerous-command-in-%post rm virt-manager-tui.noarch: W: no-documentation virt-manager-tui.noarch: E: non-executable-script /usr/share/virt-manager/virtManagerTui/startnetwork.py 0644L /usr/bin/env virt-manager-tui.noarch: W: no-manual-page-for-binary virt-manager-tui 2 packages and 0 specfiles checked; 3 errors, 7 warnings. Requires -------- virt-manager-tui (rpmlib, GLIBC filtered): /bin/sh libuser-python python-IPy python-newt_syrup virt-manager-common virt-manager (rpmlib, GLIBC filtered): /bin/sh GConf2 dbus-python dbus-x11 desktop-file-utils gnome-python2-gconf gnome-python2-gnomekeyring gtk-vnc-python libgnome-keyring libvirt-python libxml2-python pygtk2 python-virtinst scrollkeeper spice-gtk-python virt-manager-common vte Provides -------- virt-manager-tui: virt-manager-tui virt-manager: virt-manager MD5-sum check ------------- http://virt-manager.org/download/sources/virt-manager/virt-manager-0.9.4.tar.gz : CHECKSUM(SHA256) this package : dc8c553beeb15bb30cd5517b2105bcc47cf482b03523e522733c52b0e5df0fc0 CHECKSUM(SHA256) upstream package : dc8c553beeb15bb30cd5517b2105bcc47cf482b03523e522733c52b0e5df0fc0 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn virt-manager -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires