Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 2 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: virt-what-1.12-2.fc18.x86_64.rpm virt-what.x86_64: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization virt-what.x86_64: W: spelling-error %description -l en_US hyperv -> hyper, hyper v, Hyperion virt-what.x86_64: W: spelling-error %description -l en_US kvm -> km virt-what.x86_64: W: spelling-error %description -l en_US openvz -> open virt-what.x86_64: W: spelling-error %description -l en_US powervm -> power virt-what.x86_64: W: spelling-error %description -l en_US qemu -> emu, q emu virt-what.x86_64: W: spelling-error %description -l en_US unaccelerated -> accelerated, unadulterated, accelerate virt-what.x86_64: W: spelling-error %description -l en_US uml -> um, ml, ump virt-what.x86_64: W: spelling-error %description -l en_US virtage -> vintage, vicarage virt-what.x86_64: W: spelling-error %description -l en_US virtualbox -> virtual box, virtual-box, virtual virt-what.x86_64: W: spelling-error %description -l en_US virtualpc -> virtual virt-what.x86_64: W: spelling-error %description -l en_US vmware -> stemware virt-what.x86_64: W: spelling-error %description -l en_US xen -> zen, en, oxen virt-what.x86_64: W: spelling-error %description -l en_US domU -> do Mu, dome, do-mu virt-what.x86_64: W: spelling-error %description -l en_US paravirtualized -> departmentalized virt-what.x86_64: W: spelling-error %description -l en_US hvm -> hem, him, ham virt-what.x86_64: W: spelling-error %description -l en_US virtualized -> ritualized, visualized, actualized virt-what.x86_64: E: incorrect-fsf-address /usr/sbin/virt-what virt-what.x86_64: E: incorrect-fsf-address /usr/share/doc/virt-what-1.12/COPYING 1 packages and 0 specfiles checked; 2 errors, 17 warnings. Requires -------- virt-what (rpmlib, GLIBC filtered): /bin/bash dmidecode libc.so.6()(64bit) rtld(GNU_HASH) util-linux Provides -------- virt-what: virt-what virt-what(x86-64) MD5-sum check ------------- http://people.redhat.com/~rjones/virt-what/files/virt-what-1.12.tar.gz : CHECKSUM(SHA256) this package : 2592082f5b2caa93d3967b7c275a3afabfe49de9f051fdf0da6ded59e2c11b1c CHECKSUM(SHA256) upstream package : 2592082f5b2caa93d3967b7c275a3afabfe49de9f051fdf0da6ded59e2c11b1c Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn virt-what -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires