Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked when required Note: icons in x3270-x11 See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - update-desktop-database is invoked when required Note: desktop file(s) in x3270-x11 See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Large documentation must go in a -doc subpackage. Note: Documentation size is 1013760 bytes in 68 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in x3270-x11 , x3270-text [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define fontdir %{_datadir}/x3270/fonts %define catalogue /etc/X11/fontpath.d %define majorver 3.3 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1280000 bytes in /usr/share 1054720 x3270-3.3.12ga11-4.fc19.x86_64.rpm 204800 x3270-x11-3.3.12ga11-4.fc19.x86_64.rpm 20480 x3270-text-3.3.12ga11-4.fc19.x86_64.rpm Rpmlint ------- Checking: x3270-3.3.12ga11-4.fc19.x86_64.rpm x3270-x11-3.3.12ga11-4.fc19.x86_64.rpm x3270-text-3.3.12ga11-4.fc19.x86_64.rpm x3270.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end x3270.x86_64: W: spelling-error %description -l en_US frontends -> front ends, front-ends, fronds x3270-x11.x86_64: W: no-documentation x3270-x11.x86_64: W: no-manual-page-for-binary x3270 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- x3270-text (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libncursesw.so.5()(64bit) libreadline.so.6()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libtinfo.so.5()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) x3270 x3270-x11 (rpmlib, GLIBC filtered): /bin/sh /usr/bin/mkfontdir libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXaw.so.7()(64bit) libXext.so.6()(64bit) libXmu.so.6()(64bit) libXt.so.6()(64bit) libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) x3270 x3270 (rpmlib, GLIBC filtered): config(x3270) libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) Provides -------- x3270-text: x3270-text x3270-text(x86-64) x3270-x11: x3270-x11 x3270-x11(x86-64) x3270: config(x3270) x3270 x3270(x86-64) MD5-sum check ------------- http://downloads.sourceforge.net/x3270/suite3270-3.3.12ga11-src.tgz : CHECKSUM(SHA256) this package : 444b2ddadf4a46b9d7ace0a20d4baf2ccbb4b744328cdba368cabc5fc8bd27b6 CHECKSUM(SHA256) upstream package : 444b2ddadf4a46b9d7ace0a20d4baf2ccbb4b744328cdba368cabc5fc8bd27b6 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn x3270 -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires