Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define pkgname apps [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: xorg-x11-apps-7.7-4.fc19.x86_64.rpm xorg-x11-apps.x86_64: W: obsolete-not-provided XFree86 xorg-x11-apps.x86_64: W: obsolete-not-provided xorg-x11 xorg-x11-apps.x86_64: W: obsolete-not-provided XFree86-tools xorg-x11-apps.x86_64: W: obsolete-not-provided xorg-x11-tools xorg-x11-apps.x86_64: W: manual-page-warning /usr/share/man/man1/xclipboard.1.gz 89: warning: macro `TA' not defined xorg-x11-apps.x86_64: W: manual-page-warning /usr/share/man/man1/xlogo.1.gz 67: warning: macro `TA' not defined 1 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- xorg-x11-apps (rpmlib, GLIBC filtered): /bin/sh libSM.so.6()(64bit) libX11.so.6()(64bit) libXaw.so.7()(64bit) libXcursor.so.1()(64bit) libXext.so.6()(64bit) libXft.so.2()(64bit) libXmu.so.6()(64bit) libXmuu.so.1()(64bit) libXrender.so.1()(64bit) libXt.so.6()(64bit) libXxf86vm.so.1()(64bit) libc.so.6()(64bit) libfontconfig.so.1()(64bit) libfontenc.so.1()(64bit) libm.so.6()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libutil.so.1()(64bit) libxkbfile.so.1()(64bit) rtld(GNU_HASH) Provides -------- xorg-x11-apps: luit oclock x11perf xbiff xclipboard xclock xconsole xcursorgen xeyes xfd xfontsel xload xlogo xmag xmessage xorg-x11-apps xorg-x11-apps(x86-64) xpr xvidtune xwd xwud MD5-sum check ------------- ftp://ftp.x.org/pub/individual/app/xlogo-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : 17af6f4fb73e7310e087fbfe5d773bab2b0d6f37a894ae5ee32de4693af6ba92 CHECKSUM(SHA256) upstream package : 17af6f4fb73e7310e087fbfe5d773bab2b0d6f37a894ae5ee32de4693af6ba92 ftp://ftp.x.org/pub/individual/app/xmag-1.0.5.tar.bz2 : CHECKSUM(SHA256) this package : 4ace8795cf756be4ba387f30366045594ce26adda2f5ffe1f8e896825d0932c6 CHECKSUM(SHA256) upstream package : 4ace8795cf756be4ba387f30366045594ce26adda2f5ffe1f8e896825d0932c6 ftp://ftp.x.org/pub/individual/app/xmessage-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : bcdf4b461c439bb3ade6e1e41c47d6218b912da8e9396b7ad70856db2f95ab68 CHECKSUM(SHA256) upstream package : bcdf4b461c439bb3ade6e1e41c47d6218b912da8e9396b7ad70856db2f95ab68 ftp://ftp.x.org/pub/individual/app/xcursorgen-1.0.5.tar.bz2 : CHECKSUM(SHA256) this package : bc7171a0fa212da866fca2301241630e2009aea8c4ddb75f21b51a31c2e4c581 CHECKSUM(SHA256) upstream package : bc7171a0fa212da866fca2301241630e2009aea8c4ddb75f21b51a31c2e4c581 ftp://ftp.x.org/pub/individual/app/xeyes-1.1.1.tar.bz2 : CHECKSUM(SHA256) this package : 975e98680cd59e1f9439016386609546ed08c284d0f05a95276f96aca6e8a521 CHECKSUM(SHA256) upstream package : 975e98680cd59e1f9439016386609546ed08c284d0f05a95276f96aca6e8a521 ftp://ftp.x.org/pub/individual/app/xload-1.1.1.tar.bz2 : CHECKSUM(SHA256) this package : de12f0991ef124c291e0416ca8417073fe47328e9221d4be8e4076fcee151450 CHECKSUM(SHA256) upstream package : de12f0991ef124c291e0416ca8417073fe47328e9221d4be8e4076fcee151450 ftp://ftp.x.org/pub/individual/app/xfd-1.1.1.tar.bz2 : CHECKSUM(SHA256) this package : 3fbef0d5ed6dc088017df156e748d187b2d1aaedc3de7ea96e505ea6d1af7b73 CHECKSUM(SHA256) upstream package : 3fbef0d5ed6dc088017df156e748d187b2d1aaedc3de7ea96e505ea6d1af7b73 ftp://ftp.x.org/pub/individual/app/xfontsel-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : 25491e9b7762607299f8a7099c97452d9b83e92266f8b0579b380ca01e5a5f7e CHECKSUM(SHA256) upstream package : 25491e9b7762607299f8a7099c97452d9b83e92266f8b0579b380ca01e5a5f7e ftp://ftp.x.org/pub/individual/app/xwd-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : b7a6c889911a0ab52f9f92a83658abb81e213969ad4e6c73c11c9274a438b01e CHECKSUM(SHA256) upstream package : b7a6c889911a0ab52f9f92a83658abb81e213969ad4e6c73c11c9274a438b01e ftp://ftp.x.org/pub/individual/app/xwud-1.0.3.tar.bz2 : CHECKSUM(SHA256) this package : 88fdeae05cc3bcc35dfbf0df1606bc4ed4a420edb1abf96aececbc1bd7332c43 CHECKSUM(SHA256) upstream package : 88fdeae05cc3bcc35dfbf0df1606bc4ed4a420edb1abf96aececbc1bd7332c43 ftp://ftp.x.org/pub/individual/app/oclock-1.0.3.tar.bz2 : CHECKSUM(SHA256) this package : 54f5fb85f5828705683f457e559fb18753332db15ae82da561b0ae5a63915091 CHECKSUM(SHA256) upstream package : 54f5fb85f5828705683f457e559fb18753332db15ae82da561b0ae5a63915091 ftp://ftp.x.org/pub/individual/app/xclock-1.0.6.tar.bz2 : CHECKSUM(SHA256) this package : 21bb6f57b0a158c05a47558302321c4764a8d2e1b8e5d4ad23e3809b4cee3fd0 CHECKSUM(SHA256) upstream package : 21bb6f57b0a158c05a47558302321c4764a8d2e1b8e5d4ad23e3809b4cee3fd0 ftp://ftp.x.org/pub/individual/app/x11perf-1.5.4.tar.bz2 : CHECKSUM(SHA256) this package : 24ee8857a2bf414b360addabf1c27ef797f7f504ee9bc409c151760bfbe53184 CHECKSUM(SHA256) upstream package : 24ee8857a2bf414b360addabf1c27ef797f7f504ee9bc409c151760bfbe53184 ftp://ftp.x.org/pub/individual/app/xbiff-1.0.3.tar.bz2 : CHECKSUM(SHA256) this package : aa1db4f31f7afcfe131bda7ff6e380ff7de41cf1a7009464783043c817c47ce8 CHECKSUM(SHA256) upstream package : aa1db4f31f7afcfe131bda7ff6e380ff7de41cf1a7009464783043c817c47ce8 ftp://ftp.x.org/pub/individual/app/xpr-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : fed98df31eb93d3dca4688cb535aabad06be572e70ace3b1685679c18dd86cb5 CHECKSUM(SHA256) upstream package : fed98df31eb93d3dca4688cb535aabad06be572e70ace3b1685679c18dd86cb5 ftp://ftp.x.org/pub/individual/app/luit-1.1.1.tar.bz2 : CHECKSUM(SHA256) this package : 30b0e787cb07a0f504b70f1d6123930522111ce9d4276f6683a69b322b49c636 CHECKSUM(SHA256) upstream package : 30b0e787cb07a0f504b70f1d6123930522111ce9d4276f6683a69b322b49c636 ftp://ftp.x.org/pub/individual/app/xclipboard-1.1.2.tar.bz2 : CHECKSUM(SHA256) this package : 5f3b12da1eae4ed24883d8a5633b6150a0291deede818aeb5c9e827599b6429e CHECKSUM(SHA256) upstream package : 5f3b12da1eae4ed24883d8a5633b6150a0291deede818aeb5c9e827599b6429e ftp://ftp.x.org/pub/individual/app/xconsole-1.0.5.tar.bz2 : CHECKSUM(SHA256) this package : 195fad7a1ca274835fc346c82acce90a0c2e9f288e85bd1a3c256dbc1c8c11e5 CHECKSUM(SHA256) upstream package : 195fad7a1ca274835fc346c82acce90a0c2e9f288e85bd1a3c256dbc1c8c11e5 ftp://ftp.x.org/pub/individual/app/xvidtune-1.0.3.tar.bz2 : CHECKSUM(SHA256) this package : 24e5e103933a04bfb2e1d18562619ed74031ab515e7343eb546bacdbcbeecf01 CHECKSUM(SHA256) upstream package : 24e5e103933a04bfb2e1d18562619ed74031ab515e7343eb546bacdbcbeecf01 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn xorg-x11-apps -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires