Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 337920 bytes in 36 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define build_bootstrap 1 %define debug_package %{nil} [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: xorg-x11-proto-devel-7.7-1.fc19.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- xorg-x11-proto-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config pkgconfig pkgconfig(xextproto) Provides -------- xorg-x11-proto-devel: pkgconfig(bigreqsproto) pkgconfig(compositeproto) pkgconfig(damageproto) pkgconfig(dmxproto) pkgconfig(dri2proto) pkgconfig(evieproto) pkgconfig(fixesproto) pkgconfig(fontsproto) pkgconfig(glproto) pkgconfig(inputproto) pkgconfig(kbproto) pkgconfig(randrproto) pkgconfig(recordproto) pkgconfig(renderproto) pkgconfig(resourceproto) pkgconfig(scrnsaverproto) pkgconfig(videoproto) pkgconfig(xcmiscproto) pkgconfig(xextproto) pkgconfig(xf86bigfontproto) pkgconfig(xf86dgaproto) pkgconfig(xf86driproto) pkgconfig(xf86miscproto) pkgconfig(xf86vidmodeproto) pkgconfig(xineramaproto) pkgconfig(xproto) pkgconfig(xproxymngproto) xorg-x11-proto-devel MD5-sum check ------------- http://xorg.freedesktop.org/archive/individual/proto/xproxymanagementprotocol-1.0.3.tar.bz2 : CHECKSUM(SHA256) this package : 7382acd8c76fa577beb622cab86cc07fafdcecbbd9b4f209bfa72976c4fd26c2 CHECKSUM(SHA256) upstream package : 7382acd8c76fa577beb622cab86cc07fafdcecbbd9b4f209bfa72976c4fd26c2 http://xorg.freedesktop.org/archive/individual/proto/dri2proto-2.8.tar.bz2 : CHECKSUM(SHA256) this package : f9b55476def44fc7c459b2537d17dbc731e36ed5d416af7ca0b1e2e676f8aa04 CHECKSUM(SHA256) upstream package : f9b55476def44fc7c459b2537d17dbc731e36ed5d416af7ca0b1e2e676f8aa04 http://xorg.freedesktop.org/archive/individual/proto/recordproto-1.14.2.tar.bz2 : CHECKSUM(SHA256) this package : a777548d2e92aa259f1528de3c4a36d15e07a4650d0976573a8e2ff5437e7370 CHECKSUM(SHA256) upstream package : a777548d2e92aa259f1528de3c4a36d15e07a4650d0976573a8e2ff5437e7370 http://xorg.freedesktop.org/archive/individual/proto/renderproto-0.11.1.tar.bz2 : CHECKSUM(SHA256) this package : 06735a5b92b20759204e4751ecd6064a2ad8a6246bb65b3078b862a00def2537 CHECKSUM(SHA256) upstream package : 06735a5b92b20759204e4751ecd6064a2ad8a6246bb65b3078b862a00def2537 http://xorg.freedesktop.org/archive/individual/proto/resourceproto-1.2.0.tar.bz2 : CHECKSUM(SHA256) this package : 3c66003a6bdeb0f70932a9ed3cf57cc554234154378d301e0c5cfa189d8f6818 CHECKSUM(SHA256) upstream package : 3c66003a6bdeb0f70932a9ed3cf57cc554234154378d301e0c5cfa189d8f6818 http://xorg.freedesktop.org/archive/individual/proto/scrnsaverproto-1.2.2.tar.bz2 : CHECKSUM(SHA256) this package : 8bb70a8da164930cceaeb4c74180291660533ad3cc45377b30a795d1b85bcd65 CHECKSUM(SHA256) upstream package : 8bb70a8da164930cceaeb4c74180291660533ad3cc45377b30a795d1b85bcd65 http://xorg.freedesktop.org/archive/individual/proto/kbproto-1.0.6.tar.bz2 : CHECKSUM(SHA256) this package : 037cac0aeb80c4fccf44bf736d791fccb2ff7fd34c558ef8f03ac60b61085479 CHECKSUM(SHA256) upstream package : 037cac0aeb80c4fccf44bf736d791fccb2ff7fd34c558ef8f03ac60b61085479 http://xorg.freedesktop.org/archive/individual/proto/randrproto-1.4.0.tar.bz2 : CHECKSUM(SHA256) this package : 85c42e8c66a55318ddaf2ce5727beacb25cb1f8555229f778cd1da86478209cf CHECKSUM(SHA256) upstream package : 85c42e8c66a55318ddaf2ce5727beacb25cb1f8555229f778cd1da86478209cf http://xorg.freedesktop.org/archive/individual/proto/videoproto-2.3.1.tar.bz2 : CHECKSUM(SHA256) this package : 3ec76d24931d1e08c6c8d0b89a25e32dc44bc8f87d1dcb3fe201e3c99f89635a CHECKSUM(SHA256) upstream package : 3ec76d24931d1e08c6c8d0b89a25e32dc44bc8f87d1dcb3fe201e3c99f89635a http://xorg.freedesktop.org/archive/individual/proto/damageproto-1.2.1.tar.bz2 : CHECKSUM(SHA256) this package : 5c7c112e9b9ea8a9d5b019e5f17d481ae20f766cb7a4648360e7c1b46fc9fc5b CHECKSUM(SHA256) upstream package : 5c7c112e9b9ea8a9d5b019e5f17d481ae20f766cb7a4648360e7c1b46fc9fc5b http://xorg.freedesktop.org/archive/individual/proto/dmxproto-2.3.1.tar.bz2 : CHECKSUM(SHA256) this package : e72051e6a3e06b236d19eed56368117b745ca1e1a27bdc50fd51aa375bea6509 CHECKSUM(SHA256) upstream package : e72051e6a3e06b236d19eed56368117b745ca1e1a27bdc50fd51aa375bea6509 http://xorg.freedesktop.org/archive/individual/proto/bigreqsproto-1.1.2.tar.bz2 : CHECKSUM(SHA256) this package : 462116ab44e41d8121bfde947321950370b285a5316612b8fce8334d50751b1e CHECKSUM(SHA256) upstream package : 462116ab44e41d8121bfde947321950370b285a5316612b8fce8334d50751b1e http://xorg.freedesktop.org/archive/individual/proto/compositeproto-0.4.2.tar.bz2 : CHECKSUM(SHA256) this package : 049359f0be0b2b984a8149c966dd04e8c58e6eade2a4a309cf1126635ccd0cfc CHECKSUM(SHA256) upstream package : 049359f0be0b2b984a8149c966dd04e8c58e6eade2a4a309cf1126635ccd0cfc http://xorg.freedesktop.org/archive/individual/proto/fontsproto-2.1.2.tar.bz2 : CHECKSUM(SHA256) this package : 869c97e5a536a8f3c9bc8b9923780ff1f062094bab935e26f96df3d6f1aa68a9 CHECKSUM(SHA256) upstream package : 869c97e5a536a8f3c9bc8b9923780ff1f062094bab935e26f96df3d6f1aa68a9 http://xorg.freedesktop.org/archive/individual/proto/evieext-1.1.1.tar.bz2 : CHECKSUM(SHA256) this package : 1cf74114436d99f56577a90b6438a32ba31b8128c9e63842bb179aba592733fe CHECKSUM(SHA256) upstream package : 1cf74114436d99f56577a90b6438a32ba31b8128c9e63842bb179aba592733fe http://xorg.freedesktop.org/archive/individual/proto/fixesproto-5.0.tar.bz2 : CHECKSUM(SHA256) this package : ba2f3f31246bdd3f2a0acf8bd3b09ba99cab965c7fb2c2c92b7dc72870e424ce CHECKSUM(SHA256) upstream package : ba2f3f31246bdd3f2a0acf8bd3b09ba99cab965c7fb2c2c92b7dc72870e424ce http://xorg.freedesktop.org/archive/individual/proto/glproto-1.4.16.tar.bz2 : CHECKSUM(SHA256) this package : 54dd663a7f5ed702f2ff035b79edf770c2f850867ac0d55742f696bfc8b2598d CHECKSUM(SHA256) upstream package : 54dd663a7f5ed702f2ff035b79edf770c2f850867ac0d55742f696bfc8b2598d http://xorg.freedesktop.org/archive/individual/proto/inputproto-2.2.99.1.tar.bz2 : CHECKSUM(SHA256) this package : 2046e3edef74c56362be2bebda1c9129e83dc13aa1943d624c6ee76af00e15a2 CHECKSUM(SHA256) upstream package : 2046e3edef74c56362be2bebda1c9129e83dc13aa1943d624c6ee76af00e15a2 http://xorg.freedesktop.org/archive/individual/proto/xproto-7.0.23.tar.bz2 : CHECKSUM(SHA256) this package : ade04a0949ebe4e3ef34bb2183b1ae8e08f6f9c7571729c9db38212742ac939e CHECKSUM(SHA256) upstream package : ade04a0949ebe4e3ef34bb2183b1ae8e08f6f9c7571729c9db38212742ac939e http://xorg.freedesktop.org/archive/individual/proto/xineramaproto-1.2.1.tar.bz2 : CHECKSUM(SHA256) this package : 977574bb3dc192ecd9c55f59f991ec1dff340be3e31392c95deff423da52485b CHECKSUM(SHA256) upstream package : 977574bb3dc192ecd9c55f59f991ec1dff340be3e31392c95deff423da52485b http://xorg.freedesktop.org/archive/individual/proto/xf86miscproto-0.9.3.tar.bz2 : CHECKSUM(SHA256) this package : 45b8ec6a4a8ca21066dce117e09dcc88539862e616e60fb391de05b36f63b095 CHECKSUM(SHA256) upstream package : 45b8ec6a4a8ca21066dce117e09dcc88539862e616e60fb391de05b36f63b095 http://xorg.freedesktop.org/archive/individual/proto/xf86driproto-2.1.1.tar.bz2 : CHECKSUM(SHA256) this package : 9c4b8d7221cb6dc4309269ccc008a22753698ae9245a398a59df35f1404d661f CHECKSUM(SHA256) upstream package : 9c4b8d7221cb6dc4309269ccc008a22753698ae9245a398a59df35f1404d661f http://xorg.freedesktop.org/archive/individual/proto/xf86vidmodeproto-2.3.1.tar.bz2 : CHECKSUM(SHA256) this package : 45d9499aa7b73203fd6b3505b0259624afed5c16b941bd04fcf123e5de698770 CHECKSUM(SHA256) upstream package : 45d9499aa7b73203fd6b3505b0259624afed5c16b941bd04fcf123e5de698770 http://xorg.freedesktop.org/archive/individual/proto/xextproto-7.2.1.tar.bz2 : CHECKSUM(SHA256) this package : 7c53b105407ef3b2eb180a361bd672c1814524a600166a0a7dbbe76b97556d1a CHECKSUM(SHA256) upstream package : 7c53b105407ef3b2eb180a361bd672c1814524a600166a0a7dbbe76b97556d1a http://xorg.freedesktop.org/archive/individual/proto/xcmiscproto-1.2.2.tar.bz2 : CHECKSUM(SHA256) this package : b13236869372256c36db79ae39d54214172677fb79e9cdc555dceec80bd9d2df CHECKSUM(SHA256) upstream package : b13236869372256c36db79ae39d54214172677fb79e9cdc555dceec80bd9d2df http://xorg.freedesktop.org/archive/individual/proto/xf86dgaproto-2.1.tar.bz2 : CHECKSUM(SHA256) this package : ac5ef65108e1f2146286e53080975683dae49fc94680042e04bd1e2010e99050 CHECKSUM(SHA256) upstream package : ac5ef65108e1f2146286e53080975683dae49fc94680042e04bd1e2010e99050 http://xorg.freedesktop.org/archive/individual/proto/xf86bigfontproto-1.2.0.tar.bz2 : CHECKSUM(SHA256) this package : ba9220e2c4475f5ed2ddaa7287426b30089e4d29bd58d35fad57ba5ea43e1648 CHECKSUM(SHA256) upstream package : ba9220e2c4475f5ed2ddaa7287426b30089e4d29bd58d35fad57ba5ea43e1648 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn xorg-x11-proto-devel -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires