Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define pkgname server-utils %define with_xkeystone 0 [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: xorg-x11-server-utils-7.5-14.fc18.x86_64.rpm xorg-x11-server-utils.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- xorg-x11-server-utils (rpmlib, GLIBC filtered): libICE.so.6()(64bit) libX11.so.6()(64bit) libXau.so.6()(64bit) libXcursor.so.1()(64bit) libXext.so.6()(64bit) libXi.so.6()(64bit) libXinerama.so.1()(64bit) libXmu.so.6()(64bit) libXmuu.so.1()(64bit) libXrandr.so.2()(64bit) libXrender.so.1()(64bit) libXt.so.6()(64bit) libXxf86misc.so.1()(64bit) libXxf86vm.so.1()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) mcpp rtld(GNU_HASH) Provides -------- xorg-x11-server-utils: iceauth rgb sessreg xgamma xhost xinput xkill xmodmap xorg-x11-server-utils xorg-x11-server-utils(x86-64) xrandr xrdb xrefresh xset xsetmode xsetpointer xsetroot xstdcmap MD5-sum check ------------- http://www.x.org/pub/individual/app/xsetroot-1.1.0.tar.bz2 : CHECKSUM(SHA256) this package : 88f13e949e7aea126239e5c9b3fe7bb7c2ecf70c70774ae41218789d9cfe5fad CHECKSUM(SHA256) upstream package : 88f13e949e7aea126239e5c9b3fe7bb7c2ecf70c70774ae41218789d9cfe5fad http://www.x.org/pub/individual/app/xstdcmap-1.0.2.tar.bz2 : CHECKSUM(SHA256) this package : 2a2c79826109a8c8a6affec8ff1f3ddada53d20d33c8ea1dd8788385fceb9952 CHECKSUM(SHA256) upstream package : 2a2c79826109a8c8a6affec8ff1f3ddada53d20d33c8ea1dd8788385fceb9952 http://www.x.org/pub/individual/app/xkill-1.0.3.tar.bz2 : CHECKSUM(SHA256) this package : bd8307272a648ca76a266e5c1111384c8ed9367c6a8f1a5be844a5b5300881a9 CHECKSUM(SHA256) upstream package : bd8307272a648ca76a266e5c1111384c8ed9367c6a8f1a5be844a5b5300881a9 http://www.x.org/pub/individual/app/xinput-1.6.0.tar.bz2 : CHECKSUM(SHA256) this package : 4ab007d952c76665603bcb82ceb15fd3929d10faf0580fc4873ac16f5f63847e CHECKSUM(SHA256) upstream package : 4ab007d952c76665603bcb82ceb15fd3929d10faf0580fc4873ac16f5f63847e http://www.x.org/pub/individual/app/xrefresh-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : 069502eb485ea128a0bebf94302d5cbb271ad9d31ae51691abd6d64914ff9d7b CHECKSUM(SHA256) upstream package : 069502eb485ea128a0bebf94302d5cbb271ad9d31ae51691abd6d64914ff9d7b http://www.x.org/pub/individual/app/xset-1.2.2.tar.bz2 : CHECKSUM(SHA256) this package : 61371c140030b8b05075a1378b34a4d7c438ed9159496a95f10782c6f4aec1e8 CHECKSUM(SHA256) upstream package : 61371c140030b8b05075a1378b34a4d7c438ed9159496a95f10782c6f4aec1e8 http://www.x.org/pub/individual/app/xsetmode-1.0.0.tar.bz2 : CHECKSUM(SHA256) this package : 988b47cd922991c6e6adbce15dc386ac75690b61744b526c3af5a4eaa9afa0aa CHECKSUM(SHA256) upstream package : 988b47cd922991c6e6adbce15dc386ac75690b61744b526c3af5a4eaa9afa0aa http://www.x.org/pub/individual/app/xsetpointer-1.0.1.tar.bz2 : CHECKSUM(SHA256) this package : 495d88871eb5081e98bbae55f813f73cb3ce4145d6ca3e8f2826800166c04571 CHECKSUM(SHA256) upstream package : 495d88871eb5081e98bbae55f813f73cb3ce4145d6ca3e8f2826800166c04571 http://www.x.org/pub/individual/app/rgb-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : 80887da011ad086fff88bfd16c6d9d5ac7da45ef1bc9d0c192a6f370423370f1 CHECKSUM(SHA256) upstream package : 80887da011ad086fff88bfd16c6d9d5ac7da45ef1bc9d0c192a6f370423370f1 http://www.x.org/pub/individual/app/sessreg-1.0.6.tar.bz2 : CHECKSUM(SHA256) this package : 73f31670842b7d969504a61f3c694bf1911f844831c390396971ae2b74de7190 CHECKSUM(SHA256) upstream package : 73f31670842b7d969504a61f3c694bf1911f844831c390396971ae2b74de7190 http://www.x.org/pub/individual/app/iceauth-1.0.5.tar.bz2 : CHECKSUM(SHA256) this package : 1496b6a5cc8c1dca2f1b7cb24a12dee4b5c6c9ea2f03fb0dcba50b1d8ed906ab CHECKSUM(SHA256) upstream package : 1496b6a5cc8c1dca2f1b7cb24a12dee4b5c6c9ea2f03fb0dcba50b1d8ed906ab http://www.x.org/pub/individual/app/xhost-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : 5e02c06caeb7a258f3621bf11459a7820cfeaf9bf269c1f8da86d7071346a594 CHECKSUM(SHA256) upstream package : 5e02c06caeb7a258f3621bf11459a7820cfeaf9bf269c1f8da86d7071346a594 http://www.x.org/pub/individual/app/xmodmap-1.0.5.tar.bz2 : CHECKSUM(SHA256) this package : 421ee7a17b0cf559c4901225f70c497e3c5ca205ec7dcc84712055818d2f3402 CHECKSUM(SHA256) upstream package : 421ee7a17b0cf559c4901225f70c497e3c5ca205ec7dcc84712055818d2f3402 http://www.x.org/pub/individual/app/xgamma-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : 7dc8334882a060bcc90042bceac5132dd87d5acc8d043b16311ef2134aea8e16 CHECKSUM(SHA256) upstream package : 7dc8334882a060bcc90042bceac5132dd87d5acc8d043b16311ef2134aea8e16 http://www.x.org/pub/individual/app/xrandr-1.3.5.tar.bz2 : CHECKSUM(SHA256) this package : 1059ff7a9ad0df8e00a765ffa4e08a505304c02663112da370ac7082030b980e CHECKSUM(SHA256) upstream package : 1059ff7a9ad0df8e00a765ffa4e08a505304c02663112da370ac7082030b980e http://www.x.org/pub/individual/app/xrdb-1.0.9.tar.bz2 : CHECKSUM(SHA256) this package : 642401e12996efe3e5e5307a245e24c282b94a44c1f147e177c8484b862aeab7 CHECKSUM(SHA256) upstream package : 642401e12996efe3e5e5307a245e24c282b94a44c1f147e177c8484b862aeab7 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn xorg-x11-server-utils -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires