Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define pkgname utils [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: xorg-x11-utils-7.5-7.fc18.x86_64.rpm xorg-x11-utils.x86_64: W: no-manual-page-for-binary edid-decode 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- xorg-x11-utils (rpmlib, GLIBC filtered): libX11-xcb.so.1()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libXi.so.6()(64bit) libXinerama.so.1()(64bit) libXrender.so.1()(64bit) libXtst.so.6()(64bit) libXv.so.1()(64bit) libXxf86dga.so.1()(64bit) libXxf86misc.so.1()(64bit) libXxf86vm.so.1()(64bit) libc.so.6()(64bit) libdmx.so.1()(64bit) libxcb-shape.so.0()(64bit) libxcb.so.1()(64bit) rtld(GNU_HASH) Provides -------- xorg-x11-utils: edid-decode xdpyinfo xev xlsatoms xlsclients xlsfonts xorg-x11-utils xorg-x11-utils(x86-64) xprop xvinfo xwininfo MD5-sum check ------------- ftp://ftp.x.org/pub/individual/app/xwininfo-1.1.1.tar.bz2 : CHECKSUM(SHA256) this package : 645a57be4870fb6aba459e7dc96f4d8eaafa3b31bbcd42c997ac4cb021a2343d CHECKSUM(SHA256) upstream package : 645a57be4870fb6aba459e7dc96f4d8eaafa3b31bbcd42c997ac4cb021a2343d ftp://ftp.x.org/pub/individual/app/xev-1.1.0.tar.bz2 : CHECKSUM(SHA256) this package : 3859c268edb26ad0484281a244a567ef2f70ba5f91f4b5dfd37799255ccf01c6 CHECKSUM(SHA256) upstream package : 3859c268edb26ad0484281a244a567ef2f70ba5f91f4b5dfd37799255ccf01c6 ftp://ftp.x.org/pub/individual/app/xdpyinfo-1.3.0.tar.bz2 : CHECKSUM(SHA256) this package : 23ee4944a32b5701b4379cb420729eb7a4dde54de2b5b006d4747855efd6d73f CHECKSUM(SHA256) upstream package : 23ee4944a32b5701b4379cb420729eb7a4dde54de2b5b006d4747855efd6d73f ftp://ftp.x.org/pub/individual/app/xlsclients-1.1.2.tar.bz2 : CHECKSUM(SHA256) this package : 1ce5f3987b63ea79b3f8421fcb1dd9c739e99efa97f280eafd8e93574b9027d1 CHECKSUM(SHA256) upstream package : 1ce5f3987b63ea79b3f8421fcb1dd9c739e99efa97f280eafd8e93574b9027d1 ftp://ftp.x.org/pub/individual/app/xlsfonts-1.0.3.tar.bz2 : CHECKSUM(SHA256) this package : b59358b664f8220e3856d01d6b3e60adcc70f04fc588d71e0f7d9fd35e0e67c2 CHECKSUM(SHA256) upstream package : b59358b664f8220e3856d01d6b3e60adcc70f04fc588d71e0f7d9fd35e0e67c2 ftp://ftp.x.org/pub/individual/app/xlsatoms-1.1.0.tar.bz2 : CHECKSUM(SHA256) this package : 4a017ada25140a71034fc0026500ebe24b81f2d185a4b2ef733de683b79dcb0d CHECKSUM(SHA256) upstream package : 4a017ada25140a71034fc0026500ebe24b81f2d185a4b2ef733de683b79dcb0d ftp://ftp.x.org/pub/individual/app/xprop-1.2.1.tar.bz2 : CHECKSUM(SHA256) this package : 07907a189099b8a000406b5ca6c5346df238a9e1fe3b32dc59f48fe0ad12f1a3 CHECKSUM(SHA256) upstream package : 07907a189099b8a000406b5ca6c5346df238a9e1fe3b32dc59f48fe0ad12f1a3 ftp://ftp.x.org/pub/individual/app/xvinfo-1.1.1.tar.bz2 : CHECKSUM(SHA256) this package : 60c74aa190bcf1e244f6f1576dc43869018a8ed5ba319703a5c198d3466a3985 CHECKSUM(SHA256) upstream package : 60c74aa190bcf1e244f6f1576dc43869018a8ed5ba319703a5c198d3466a3985 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn xorg-x11-utils -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires