Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in xorg-x11-xinit-session See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xorg-x11 -xinit-session [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 71680 bytes in 3 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define pkgname xinit [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: xorg-x11-xinit-1.3.2-7.fc19.x86_64.rpm xorg-x11-xinit-session-1.3.2-7.fc19.x86_64.rpm xorg-x11-xinit.x86_64: W: spelling-error Summary(en_US) startup -> start up, start-up, upstart xorg-x11-xinit.x86_64: W: spelling-error %description -l en_US startup -> start up, start-up, upstart xorg-x11-xinit.x86_64: W: non-conffile-in-etc /etc/X11/xinit/xinitrc-common xorg-x11-xinit.x86_64: E: incorrect-fsf-address /etc/X11/xinit/xinitrc-common xorg-x11-xinit.x86_64: E: incorrect-fsf-address /etc/X11/xinit/Xsession xorg-x11-xinit.x86_64: W: manual-page-warning /usr/share/man/man1/startx.1.gz 106: warning: macro `.' not defined xorg-x11-xinit.x86_64: E: incorrect-fsf-address /etc/X11/xinit/xinitrc xorg-x11-xinit.x86_64: E: incorrect-fsf-address /etc/X11/xinit/Xclients xorg-x11-xinit.x86_64: E: incorrect-fsf-address /etc/X11/xinit/xinitrc.d/localuser.sh xorg-x11-xinit-session.x86_64: W: spelling-error Summary(en_US) xsession -> session, x session, secession xorg-x11-xinit-session.x86_64: W: spelling-error Summary(en_US) Xclients -> Clients, X clients, Client xorg-x11-xinit-session.x86_64: W: spelling-error %description -l en_US xsession -> session, x session, secession xorg-x11-xinit-session.x86_64: W: spelling-error %description -l en_US Xclients -> Clients, X clients, Client xorg-x11-xinit-session.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 5 errors, 9 warnings. Requires -------- xorg-x11-xinit (rpmlib, GLIBC filtered): /bin/bash /bin/sh config(xorg-x11-xinit) coreutils libX11.so.6()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) xorg-x11-server-utils xorg-x11-xauth xorg-x11-xinit-session (rpmlib, GLIBC filtered): /bin/sh Provides -------- xorg-x11-xinit: config(xorg-x11-xinit) xorg-x11-xinit xorg-x11-xinit(x86-64) xorg-x11-xinit-session: xorg-x11-xinit-session xorg-x11-xinit-session(x86-64) MD5-sum check ------------- ftp://ftp.x.org/pub/individual/app/xinit-1.3.2.tar.bz2 : CHECKSUM(SHA256) this package : a1867fdaa83f68750b12ba4305c3c62f5992d0f52cfeb98e96c27a8e690e0235 CHECKSUM(SHA256) upstream package : a1867fdaa83f68750b12ba4305c3c62f5992d0f52cfeb98e96c27a8e690e0235 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn xorg-x11-xinit -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires