Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xorg-x11 -xkb-utils-devel , xorg-x11-xkb-extras [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 2 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define xkbutils_version 1.0.3 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: xorg-x11-xkb-utils-7.7-4.fc19.x86_64.rpm xorg-x11-xkb-utils-devel-7.7-4.fc19.x86_64.rpm xorg-x11-xkb-extras-7.7-4.fc19.x86_64.rpm xorg-x11-xkb-utils.x86_64: W: obsolete-not-provided XFree86 xorg-x11-xkb-utils.x86_64: W: obsolete-not-provided xorg-x11 xorg-x11-xkb-utils-devel.x86_64: W: summary-ended-with-dot C X.Org X11 xkb utilities development package. xorg-x11-xkb-utils-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- xorg-x11-xkb-utils (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libc.so.6()(64bit) libxkbfile.so.1()(64bit) rtld(GNU_HASH) xorg-x11-xkb-extras (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libXaw.so.7()(64bit) libXt.so.6()(64bit) libc.so.6()(64bit) libxkbfile.so.1()(64bit) rtld(GNU_HASH) xorg-x11-xkb-utils-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config pkgconfig pkgconfig(x11) pkgconfig(xkbfile) pkgconfig(xproto) Provides -------- xorg-x11-xkb-utils: setxkbmap xkbcomp xorg-x11-xkb-utils xorg-x11-xkb-utils(x86-64) xorg-x11-xkb-extras: xkbevd xkbprint xkbutils xorg-x11-xkb-extras xorg-x11-xkb-extras(x86-64) xorg-x11-xkb-utils-devel: pkgconfig(xkbcomp) xorg-x11-xkb-utils-devel xorg-x11-xkb-utils-devel(x86-64) MD5-sum check ------------- ftp://ftp.x.org/pub/individual/app/xkbevd-1.1.3.tar.bz2 : CHECKSUM(SHA256) this package : 55b2484f9851112c2685d503b64b319f0f98fce74863ef735ecd52b52ceb0116 CHECKSUM(SHA256) upstream package : 55b2484f9851112c2685d503b64b319f0f98fce74863ef735ecd52b52ceb0116 ftp://ftp.x.org/pub/individual/app/xkbprint-1.0.3.tar.bz2 : CHECKSUM(SHA256) this package : fa846db8e588018134bd550f80eb129e4ddfdb96f3b157603a57ae2cdf5892c0 CHECKSUM(SHA256) upstream package : fa846db8e588018134bd550f80eb129e4ddfdb96f3b157603a57ae2cdf5892c0 ftp://ftp.x.org/pub/individual/app/xkbutils-1.0.3.tar.bz2 : CHECKSUM(SHA256) this package : e409af0730788aa94ee22711750792546465a8f4729a0084d31a32c3ef0849bd CHECKSUM(SHA256) upstream package : e409af0730788aa94ee22711750792546465a8f4729a0084d31a32c3ef0849bd ftp://ftp.x.org/pub/individual/app/xkbcomp-1.2.4.tar.bz2 : CHECKSUM(SHA256) this package : 91d0c9ab445d21dfe1892dbae5ae5264f39bae68223dd092ffc547c9450b5a2d CHECKSUM(SHA256) upstream package : 91d0c9ab445d21dfe1892dbae5ae5264f39bae68223dd092ffc547c9450b5a2d ftp://ftp.x.org/pub/individual/app/setxkbmap-1.3.0.tar.bz2 : CHECKSUM(SHA256) this package : 3d305c9d1f38224169b2e501ef0665cc3ab52d4dbc2b9a60c9dbb047f77ddec6 CHECKSUM(SHA256) upstream package : 3d305c9d1f38224169b2e501ef0665cc3ab52d4dbc2b9a60c9dbb047f77ddec6 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn xorg-x11-xkb-utils -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires